[jbossws-issues] [JBoss JIRA] (JBWS-4056) Ensure all tests are written junit4 way

[Jan Blizňák (JIRA)]

    [ https://issues.jboss.org/browse/JBWS-4056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13360595#comment-13360595 ] 

Jan Blizňák commented on JBWS-4056:
-----------------------------------

so far found these not executed tests:

not executed test methods:
https://github.com/jbossws/jbossws-cxf/blob/master/modules/testsuite/cxf-tests/src/test/java/org/jboss/test/ws/jaxws/cxf/httpproxy/HTTPProxyTestCaseForked.java#L273-L312
https://github.com/jbossws/jbossws-cxf/blob/master/modules/testsuite/shared-tests/src/test/java/org/jboss/test/ws/jaxws/samples/xop/doclit/XOPBase.java#L74-L139
https://github.com/jbossws/jbossws-cxf/blob/master/modules/testsuite/shared-tests/src/test/java/org/jboss/test/ws/jaxws/samples/exception/ExceptionServletTestCase.java#L89-L112

not executed testcases:
https://github.com/jbossws/jbossws-cxf/blob/master/modules/testsuite/shared-tests/src/test/java/org/jboss/test/ws/jaxws/smoke/tools/WSConsumerPlugin.java
https://github.com/jbossws/jbossws-cxf/blob/master/modules/testsuite/shared-tests/src/test/java/org/jboss/test/ws/jaxws/smoke/tools/WSProviderPlugin.java



> Ensure all tests are written junit4 way
> ---------------------------------------
>
>                 Key: JBWS-4056
>                 URL: https://issues.jboss.org/browse/JBWS-4056
>             Project: JBoss Web Services
>          Issue Type: Task
>          Components: jbossws-cxf
>    Affects Versions: jbossws-cxf-5.1.7.Final
>            Reporter: Jan Blizňák
>
> Currently most of the tests in JBWS project are written using @RunWith(Arquillian.class) whereas there are others extending TestCase class from junit framework. The latter is the junit3 way of writing tests which relies on test method name convention.
> Furthermore, almost all tests transitively extends TestCase via JBossWSTest despite of using @RunWith. In some cases that leads to situations where some test methods are actually skipped because they miss @Test annotation, which were probably missed within migration to Arquillian.
> We should ensure all tests use junit4 runners, ie. either @RunWith(JUnit4.class) or @RunWith(Arquillian.class). We also should remove inheritance from TestCase class and instead use Assert.* methods directly.



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)