[jbpm-commits] JBoss JBPM SVN: r1907 - in jbossbpm/spec/trunk/modules: dialects/api10/src/main/java/org/jboss/bpm/dialect/api10 and 6 other directories.

do-not-reply at jboss.org do-not-reply at jboss.org
Sat Aug 16 05:20:29 EDT 2008


Author: thomas.diesler at jboss.com
Date: 2008-08-16 05:20:28 -0400 (Sat, 16 Aug 2008)
New Revision: 1907

Added:
   jbossbpm/spec/trunk/modules/dialects/api10/src/main/java/org/jboss/bpm/dialect/api10/model/JAXBConditionalEventDetail.java
   jbossbpm/spec/trunk/modules/dialects/api10/src/main/java/org/jboss/bpm/dialect/api10/model/JAXBMessageEventDetail.java
   jbossbpm/spec/trunk/modules/dialects/api10/src/main/java/org/jboss/bpm/dialect/api10/model/JAXBTimerEventDetail.java
Modified:
   jbossbpm/spec/trunk/modules/api/src/main/java/org/jboss/bpm/NotImplementedException.java
   jbossbpm/spec/trunk/modules/dialects/api10/src/main/java/org/jboss/bpm/dialect/api10/ProcessMarshaller.java
   jbossbpm/spec/trunk/modules/dialects/api10/src/main/java/org/jboss/bpm/dialect/api10/ProcessUnmarshaller.java
   jbossbpm/spec/trunk/modules/dialects/jpdl32/src/main/java/org/jboss/bpm/dialect/jpdl32/DialectHandlerImpl.java
   jbossbpm/spec/trunk/modules/dialects/stp/src/main/java/org/jboss/bpm/dialect/stp/DialectHandlerImpl.java
   jbossbpm/spec/trunk/modules/dialects/xpdl21/src/main/java/org/jboss/bpm/dialect/xpdl21/DialectHandlerImpl.java
   jbossbpm/spec/trunk/modules/ri/src/main/java/org/jboss/bpm/model/internal/ActivityImpl.java
   jbossbpm/spec/trunk/modules/ri/src/main/java/org/jboss/bpm/model/internal/ComplexGatewayImpl.java
   jbossbpm/spec/trunk/modules/ri/src/main/java/org/jboss/bpm/model/internal/EventBuilderImpl.java
   jbossbpm/spec/trunk/modules/ri/src/main/java/org/jboss/bpm/model/internal/ExclusiveGatewayDataBasedImpl.java
   jbossbpm/spec/trunk/modules/ri/src/main/java/org/jboss/bpm/model/internal/GateImpl.java
   jbossbpm/spec/trunk/modules/ri/src/main/java/org/jboss/bpm/model/internal/HandlerImpl.java
   jbossbpm/spec/trunk/modules/ri/src/main/java/org/jboss/bpm/model/internal/MessageFlowImpl.java
   jbossbpm/spec/trunk/modules/ri/src/main/java/org/jboss/bpm/model/internal/ProcessBuilderImpl.java
   jbossbpm/spec/trunk/modules/ri/src/main/java/org/jboss/bpm/model/internal/ProcessImpl.java
   jbossbpm/spec/trunk/modules/ri/src/main/java/org/jboss/bpm/model/internal/ReceiveTaskImpl.java
   jbossbpm/spec/trunk/modules/ri/src/main/java/org/jboss/bpm/model/internal/TokenExecutorImpl.java
   jbossbpm/spec/trunk/modules/samples/airticket/server/src/main/java/org/jboss/bpm/samples/airticket/server/AirticketServiceImpl.java
Log:
Link NotImplementedException to JIRA

Modified: jbossbpm/spec/trunk/modules/api/src/main/java/org/jboss/bpm/NotImplementedException.java
===================================================================
--- jbossbpm/spec/trunk/modules/api/src/main/java/org/jboss/bpm/NotImplementedException.java	2008-08-15 14:49:51 UTC (rev 1906)
+++ jbossbpm/spec/trunk/modules/api/src/main/java/org/jboss/bpm/NotImplementedException.java	2008-08-16 09:20:28 UTC (rev 1907)
@@ -32,13 +32,8 @@
 @SuppressWarnings("serial")
 public class NotImplementedException extends RuntimeException
 {
-  public NotImplementedException()
+  public NotImplementedException(String jiraIssue, String message)
   {
-    super();
+    super("[" + jiraIssue + "] " + message);
   }
-
-  public NotImplementedException(String message)
-  {
-    super(message);
-  }
 }

Modified: jbossbpm/spec/trunk/modules/dialects/api10/src/main/java/org/jboss/bpm/dialect/api10/ProcessMarshaller.java
===================================================================
--- jbossbpm/spec/trunk/modules/dialects/api10/src/main/java/org/jboss/bpm/dialect/api10/ProcessMarshaller.java	2008-08-15 14:49:51 UTC (rev 1906)
+++ jbossbpm/spec/trunk/modules/dialects/api10/src/main/java/org/jboss/bpm/dialect/api10/ProcessMarshaller.java	2008-08-16 09:20:28 UTC (rev 1907)
@@ -68,7 +68,9 @@
 import org.jboss.bpm.model.Gateway;
 import org.jboss.bpm.model.InclusiveGateway;
 import org.jboss.bpm.model.InputSet;
+import org.jboss.bpm.model.IntermediateEvent;
 import org.jboss.bpm.model.Message;
+import org.jboss.bpm.model.MessageFlow;
 import org.jboss.bpm.model.OutputSet;
 import org.jboss.bpm.model.ParallelGateway;
 import org.jboss.bpm.model.Participant;
@@ -140,7 +142,7 @@
       }
       else
       {
-        throw new NotImplementedException(fo.toString());
+        throw new IllegalStateException("Unsupported flow object: " + fo);
       }
       jaxbProc.getFlowObjects().add(jaxb);
     }
@@ -156,11 +158,27 @@
       JAXBStartEvent jaxbStart = new JAXBStartEvent();
       jaxbStart.setName(start.getName());
       jaxbStart.setOutFlow(getJAXBFlow(start.getOutFlow()));
+      
+      if (start.getTrigger().size() > 1)
+        throw new NotImplementedException("JBPM-1660", "StartTrigger Multiple");
+      
       for (EventDetail trigger : start.getTrigger())
       {
         EventDetailType type = trigger.getEventDetailType();
-        if (type == EventDetailType.Signal)
+        if (type == EventDetailType.Message)
         {
+          throw new NotImplementedException("JBPM-1657", "StartTrigger Message");
+        }
+        else if (type == EventDetailType.Timer)
+        {
+          throw new NotImplementedException("JBPM-1658", "StartTrigger Timer");
+        }
+        else if (type == EventDetailType.Conditional)
+        {
+          throw new NotImplementedException("JBPM-1659", "StartTrigger Conditional");
+        }
+        else if (type == EventDetailType.Signal)
+        {
           SignalEventDetail signalTrigger = (SignalEventDetail)trigger;
           Signal signal = signalTrigger.getSignalRef();
           JAXBSignalEventDetail jaxbTrigger = new JAXBSignalEventDetail();
@@ -169,11 +187,15 @@
         }
         else
         {
-          throw new NotImplementedException("Trigger: " + type);
+          throw new IllegalStateException("Unsupported start trigger: " + type);
         }
       }
       jaxb = jaxbStart;
     }
+    else if (event instanceof IntermediateEvent)
+    {
+      throw new NotImplementedException("JBPM-1661", "IntermediateEvent");
+    }
     else if (event instanceof EndEvent)
     {
       EndEvent end = (EndEvent)event;
@@ -183,7 +205,7 @@
     }
     else
     {
-      throw new NotImplementedException(event.toString());
+      throw new IllegalStateException("Unsupported Event: " + event);
     }
     if (event instanceof HandlerSupport)
     {
@@ -267,7 +289,7 @@
     }
     else
     {
-      throw new NotImplementedException(gateway.toString());
+      throw new IllegalStateException("Unsupported gateway: " + gateway);
     }
     jaxb.setName(gateway.getName());
     if (gateway instanceof HandlerSupport)
@@ -359,9 +381,13 @@
       }
       jaxb = jaxbSeq;
     }
+    else if (flow instanceof MessageFlow)
+    {
+      throw new NotImplementedException("JBPM-1382", "Message Flow");
+    }
     else
     {
-      throw new NotImplementedException(flow.toString());
+      throw new IllegalStateException("Unsupported connectiong object: " + flow);
     }
     jaxb.setName(flow.getName());
     jaxb.setTargetName(flow.getTargetName());

Modified: jbossbpm/spec/trunk/modules/dialects/api10/src/main/java/org/jboss/bpm/dialect/api10/ProcessUnmarshaller.java
===================================================================
--- jbossbpm/spec/trunk/modules/dialects/api10/src/main/java/org/jboss/bpm/dialect/api10/ProcessUnmarshaller.java	2008-08-15 14:49:51 UTC (rev 1906)
+++ jbossbpm/spec/trunk/modules/dialects/api10/src/main/java/org/jboss/bpm/dialect/api10/ProcessUnmarshaller.java	2008-08-16 09:20:28 UTC (rev 1907)
@@ -40,6 +40,7 @@
 import org.jboss.bpm.client.ObjectNameFactory;
 import org.jboss.bpm.client.ProcessManager;
 import org.jboss.bpm.dialect.api10.model.JAXBComplexGateway;
+import org.jboss.bpm.dialect.api10.model.JAXBConditionalEventDetail;
 import org.jboss.bpm.dialect.api10.model.JAXBEndEvent;
 import org.jboss.bpm.dialect.api10.model.JAXBEvent;
 import org.jboss.bpm.dialect.api10.model.JAXBEventDetail;
@@ -52,7 +53,10 @@
 import org.jboss.bpm.dialect.api10.model.JAXBInclude;
 import org.jboss.bpm.dialect.api10.model.JAXBInclusiveGateway;
 import org.jboss.bpm.dialect.api10.model.JAXBInputSet;
+import org.jboss.bpm.dialect.api10.model.JAXBIntermediateEvent;
 import org.jboss.bpm.dialect.api10.model.JAXBMessage;
+import org.jboss.bpm.dialect.api10.model.JAXBMessageEventDetail;
+import org.jboss.bpm.dialect.api10.model.JAXBMessageFlow;
 import org.jboss.bpm.dialect.api10.model.JAXBMessageRef;
 import org.jboss.bpm.dialect.api10.model.JAXBOutputSet;
 import org.jboss.bpm.dialect.api10.model.JAXBParallelGateway;
@@ -64,6 +68,7 @@
 import org.jboss.bpm.dialect.api10.model.JAXBStartEvent;
 import org.jboss.bpm.dialect.api10.model.JAXBSupportingElement;
 import org.jboss.bpm.dialect.api10.model.JAXBTask;
+import org.jboss.bpm.dialect.api10.model.JAXBTimerEventDetail;
 import org.jboss.bpm.dialect.api10.model.ObjectFactory;
 import org.jboss.bpm.model.EventBuilder;
 import org.jboss.bpm.model.GatewayBuilder;
@@ -130,7 +135,7 @@
       }
       else
       {
-        throw new NotImplementedException(jaxb.toString());
+        throw new IllegalStateException("Unsupported flow object: " + jaxb);
       }
     }
     
@@ -194,8 +199,24 @@
     {
       JAXBStartEvent jaxbStart = (JAXBStartEvent)jaxb;
       EventBuilder eventBuilder = procBuilder.addStartEvent(jaxbStart.getName());
+      
+      if (jaxbStart.getTrigger().size() > 1)
+        throw new NotImplementedException("JBPM-1660", "StartTrigger Multiple");
+      
       for(JAXBEventDetail jaxbTrigger : jaxbStart.getTrigger())
       {
+        if (jaxbTrigger instanceof JAXBMessageEventDetail)
+        {
+          throw new NotImplementedException("JBPM-1657", "StartTrigger Message");
+        }
+        if (jaxbTrigger instanceof JAXBTimerEventDetail)
+        {
+          throw new NotImplementedException("JBPM-1658", "StartTrigger Timer");
+        }
+        if (jaxbTrigger instanceof JAXBConditionalEventDetail)
+        {
+          throw new NotImplementedException("JBPM-1659", "StartTrigger Conditional");
+        }
         if (jaxbTrigger instanceof JAXBSignalEventDetail)
         {
           JAXBSignalEventDetail jaxbSignalTrigger = (JAXBSignalEventDetail)jaxbTrigger;
@@ -204,11 +225,15 @@
         }
         else
         {
-          throw new NotImplementedException("Trigger: " + jaxbTrigger);
+          throw new IllegalStateException("Unsupported start trigger: " + jaxbTrigger);
         }
       }
       addOutFlow(procBuilder, jaxbStart.getOutFlow());
     }
+    else if (jaxb instanceof JAXBIntermediateEvent)
+    {
+      throw new NotImplementedException("JBPM-1661", "IntermediateEvent");
+    }
     else if (jaxb instanceof JAXBEndEvent)
     {
       JAXBEndEvent jaxbEnd = (JAXBEndEvent)jaxb;
@@ -216,7 +241,7 @@
     }
     else
     {
-      throw new NotImplementedException(jaxb.toString());
+      throw new IllegalStateException("Unsupported Event: " + jaxb);
     }
     procBuilder.addExecutionHandler(loadHandler(jaxb.getExecutionHandler()));
     procBuilder.addFlowHandler(loadHandler(jaxb.getFlowHandler()));
@@ -282,7 +307,7 @@
     }
     else
     {
-      throw new NotImplementedException(jaxb.toString());
+      throw new IllegalStateException("Unsupported gateway: " + jaxb);
     }
     for (JAXBFlow jaxbFlow : jaxb.getOutFlows())
     {
@@ -303,9 +328,13 @@
           gwBuilder.addGate(jaxbFlow.getTargetName());
         }
       }
+      else if (jaxbFlow instanceof JAXBMessageFlow)
+      {
+        throw new NotImplementedException("JBPM-1382", "Message Flow");
+      }
       else
       {
-        throw new NotImplementedException(jaxbFlow.toString());
+        throw new IllegalStateException("Unsupported connectiong object: " + jaxbFlow);
       }
     }
     procBuilder.addExecutionHandler(loadHandler(jaxb.getExecutionHandler()));
@@ -321,9 +350,13 @@
       {
         procBuilder.addSequenceFlow(jaxbFlow.getTargetName());
       }
+      else if (jaxbFlow instanceof JAXBMessageFlow)
+      {
+        throw new NotImplementedException("JBPM-1382", "Message Flow");
+      }
       else
       {
-        throw new NotImplementedException(jaxbFlow.toString());
+        throw new IllegalStateException("Unsupported connectiong object: " + jaxbFlow);
       }
     }
   }

Added: jbossbpm/spec/trunk/modules/dialects/api10/src/main/java/org/jboss/bpm/dialect/api10/model/JAXBConditionalEventDetail.java
===================================================================
--- jbossbpm/spec/trunk/modules/dialects/api10/src/main/java/org/jboss/bpm/dialect/api10/model/JAXBConditionalEventDetail.java	                        (rev 0)
+++ jbossbpm/spec/trunk/modules/dialects/api10/src/main/java/org/jboss/bpm/dialect/api10/model/JAXBConditionalEventDetail.java	2008-08-16 09:20:28 UTC (rev 1907)
@@ -0,0 +1,37 @@
+/*
+ * JBoss, Home of Professional Open Source
+ * Copyright 2005, JBoss Inc., and individual contributors as indicated
+ * by the @authors tag. See the copyright.txt in the distribution for a
+ * full listing of individual contributors.
+ *
+ * This is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU Lesser General Public License as
+ * published by the Free Software Foundation; either version 2.1 of
+ * the License, or (at your option) any later version.
+ *
+ * This software is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this software; if not, write to the Free
+ * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
+ * 02110-1301 USA, or see the FSF site: http://www.fsf.org.
+ */
+package org.jboss.bpm.dialect.api10.model;
+
+//$Id$
+
+import javax.xml.bind.annotation.XmlType;
+
+/**
+ * The conditional event detail
+ * 
+ * @author thomas.diesler at jboss.com
+ * @since 08-Jul-2008
+ */
+ at XmlType(name = "ConditionalEventDetail")
+public class JAXBConditionalEventDetail extends JAXBEventDetail
+{
+}
\ No newline at end of file


Property changes on: jbossbpm/spec/trunk/modules/dialects/api10/src/main/java/org/jboss/bpm/dialect/api10/model/JAXBConditionalEventDetail.java
___________________________________________________________________
Name: svn:keywords
   + Id Revision
Name: svn:eol-style
   + LF

Added: jbossbpm/spec/trunk/modules/dialects/api10/src/main/java/org/jboss/bpm/dialect/api10/model/JAXBMessageEventDetail.java
===================================================================
--- jbossbpm/spec/trunk/modules/dialects/api10/src/main/java/org/jboss/bpm/dialect/api10/model/JAXBMessageEventDetail.java	                        (rev 0)
+++ jbossbpm/spec/trunk/modules/dialects/api10/src/main/java/org/jboss/bpm/dialect/api10/model/JAXBMessageEventDetail.java	2008-08-16 09:20:28 UTC (rev 1907)
@@ -0,0 +1,37 @@
+/*
+ * JBoss, Home of Professional Open Source
+ * Copyright 2005, JBoss Inc., and individual contributors as indicated
+ * by the @authors tag. See the copyright.txt in the distribution for a
+ * full listing of individual contributors.
+ *
+ * This is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU Lesser General Public License as
+ * published by the Free Software Foundation; either version 2.1 of
+ * the License, or (at your option) any later version.
+ *
+ * This software is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this software; if not, write to the Free
+ * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
+ * 02110-1301 USA, or see the FSF site: http://www.fsf.org.
+ */
+package org.jboss.bpm.dialect.api10.model;
+
+//$Id$
+
+import javax.xml.bind.annotation.XmlType;
+
+/**
+ * The message event detail
+ * 
+ * @author thomas.diesler at jboss.com
+ * @since 08-Jul-2008
+ */
+ at XmlType(name = "MessageEventDetail")
+public class JAXBMessageEventDetail extends JAXBEventDetail
+{
+}
\ No newline at end of file


Property changes on: jbossbpm/spec/trunk/modules/dialects/api10/src/main/java/org/jboss/bpm/dialect/api10/model/JAXBMessageEventDetail.java
___________________________________________________________________
Name: svn:keywords
   + Id Revision
Name: svn:eol-style
   + LF

Added: jbossbpm/spec/trunk/modules/dialects/api10/src/main/java/org/jboss/bpm/dialect/api10/model/JAXBTimerEventDetail.java
===================================================================
--- jbossbpm/spec/trunk/modules/dialects/api10/src/main/java/org/jboss/bpm/dialect/api10/model/JAXBTimerEventDetail.java	                        (rev 0)
+++ jbossbpm/spec/trunk/modules/dialects/api10/src/main/java/org/jboss/bpm/dialect/api10/model/JAXBTimerEventDetail.java	2008-08-16 09:20:28 UTC (rev 1907)
@@ -0,0 +1,37 @@
+/*
+ * JBoss, Home of Professional Open Source
+ * Copyright 2005, JBoss Inc., and individual contributors as indicated
+ * by the @authors tag. See the copyright.txt in the distribution for a
+ * full listing of individual contributors.
+ *
+ * This is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU Lesser General Public License as
+ * published by the Free Software Foundation; either version 2.1 of
+ * the License, or (at your option) any later version.
+ *
+ * This software is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this software; if not, write to the Free
+ * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
+ * 02110-1301 USA, or see the FSF site: http://www.fsf.org.
+ */
+package org.jboss.bpm.dialect.api10.model;
+
+//$Id$
+
+import javax.xml.bind.annotation.XmlType;
+
+/**
+ * The timer event detail
+ * 
+ * @author thomas.diesler at jboss.com
+ * @since 08-Jul-2008
+ */
+ at XmlType(name = "TimerEventDetail")
+public class JAXBTimerEventDetail extends JAXBEventDetail
+{
+}
\ No newline at end of file


Property changes on: jbossbpm/spec/trunk/modules/dialects/api10/src/main/java/org/jboss/bpm/dialect/api10/model/JAXBTimerEventDetail.java
___________________________________________________________________
Name: svn:keywords
   + Id Revision
Name: svn:eol-style
   + LF

Modified: jbossbpm/spec/trunk/modules/dialects/jpdl32/src/main/java/org/jboss/bpm/dialect/jpdl32/DialectHandlerImpl.java
===================================================================
--- jbossbpm/spec/trunk/modules/dialects/jpdl32/src/main/java/org/jboss/bpm/dialect/jpdl32/DialectHandlerImpl.java	2008-08-15 14:49:51 UTC (rev 1906)
+++ jbossbpm/spec/trunk/modules/dialects/jpdl32/src/main/java/org/jboss/bpm/dialect/jpdl32/DialectHandlerImpl.java	2008-08-16 09:20:28 UTC (rev 1907)
@@ -84,6 +84,6 @@
 
   public void marshallProcess(Process proc, Writer out) throws IOException
   {
-    throw new NotImplementedException();
+    throw new NotImplementedException("JBPM-1638", "DialectHandler jPDL3.2 marshallProcess");
   }
 }
\ No newline at end of file

Modified: jbossbpm/spec/trunk/modules/dialects/stp/src/main/java/org/jboss/bpm/dialect/stp/DialectHandlerImpl.java
===================================================================
--- jbossbpm/spec/trunk/modules/dialects/stp/src/main/java/org/jboss/bpm/dialect/stp/DialectHandlerImpl.java	2008-08-15 14:49:51 UTC (rev 1906)
+++ jbossbpm/spec/trunk/modules/dialects/stp/src/main/java/org/jboss/bpm/dialect/stp/DialectHandlerImpl.java	2008-08-16 09:20:28 UTC (rev 1907)
@@ -80,6 +80,6 @@
 
   public void marshallProcess(Process proc, Writer out) throws IOException
   {
-    throw new NotImplementedException();
+    throw new NotImplementedException("JBPM-1639", "DialectHandler STP marshallProcess");
   }
 }
\ No newline at end of file

Modified: jbossbpm/spec/trunk/modules/dialects/xpdl21/src/main/java/org/jboss/bpm/dialect/xpdl21/DialectHandlerImpl.java
===================================================================
--- jbossbpm/spec/trunk/modules/dialects/xpdl21/src/main/java/org/jboss/bpm/dialect/xpdl21/DialectHandlerImpl.java	2008-08-15 14:49:51 UTC (rev 1906)
+++ jbossbpm/spec/trunk/modules/dialects/xpdl21/src/main/java/org/jboss/bpm/dialect/xpdl21/DialectHandlerImpl.java	2008-08-16 09:20:28 UTC (rev 1907)
@@ -84,6 +84,6 @@
 
   public void marshallProcess(Process proc, Writer out) throws IOException
   {
-    throw new NotImplementedException();
+    throw new NotImplementedException("JBPM-1640", "DialectHandler XPL2.1 marshallProcess");
   }
 }
\ No newline at end of file

Modified: jbossbpm/spec/trunk/modules/ri/src/main/java/org/jboss/bpm/model/internal/ActivityImpl.java
===================================================================
--- jbossbpm/spec/trunk/modules/ri/src/main/java/org/jboss/bpm/model/internal/ActivityImpl.java	2008-08-15 14:49:51 UTC (rev 1906)
+++ jbossbpm/spec/trunk/modules/ri/src/main/java/org/jboss/bpm/model/internal/ActivityImpl.java	2008-08-16 09:20:28 UTC (rev 1907)
@@ -70,12 +70,12 @@
 
   public int getStartQuantity()
   {
-    throw new NotImplementedException();
+    throw new NotImplementedException("JBPM-1631", "Activity startQuantity");
   }
 
   public int getCompletionQuantity()
   {
-    throw new NotImplementedException();
+    throw new NotImplementedException("JBPM-1632", "Activity completionQuantity");
   }
 
   public List<Expression> getIORules()
@@ -110,12 +110,12 @@
 
   public LoopType getLoopType()
   {
-    throw new NotImplementedException();
+    throw new NotImplementedException("JBPM-1633", "Activity loopType");
   }
 
   public List<String> getPerformers()
   {
-    throw new NotImplementedException();
+    throw new NotImplementedException("JBPM-1634", "Activity Performers");
   }
 
   public Property getProperty(String name)
@@ -236,7 +236,7 @@
     if (outputSets.size() > 0)
     {
       if (outputSets.size() > 1)
-        throw new NotImplementedException("IORules and multiple outputSets not supported");
+        throw new NotImplementedException("JBPM-1635", "IORules and multiple outputSets");
 
       outputSet = new OutputSetImpl();
       for (Property prop : outputSets.get(0).getProperties())

Modified: jbossbpm/spec/trunk/modules/ri/src/main/java/org/jboss/bpm/model/internal/ComplexGatewayImpl.java
===================================================================
--- jbossbpm/spec/trunk/modules/ri/src/main/java/org/jboss/bpm/model/internal/ComplexGatewayImpl.java	2008-08-15 14:49:51 UTC (rev 1906)
+++ jbossbpm/spec/trunk/modules/ri/src/main/java/org/jboss/bpm/model/internal/ComplexGatewayImpl.java	2008-08-16 09:20:28 UTC (rev 1907)
@@ -50,12 +50,12 @@
 
   public Expression getIncommingCondition()
   {
-    throw new NotImplementedException();
+    throw new NotImplementedException("JBPM-1636", "ComplexGateway incomming condition");
   }
 
   public Expression getOutgoingCondition()
   {
-    throw new NotImplementedException();
+    throw new NotImplementedException("JBPM-1637", "ComplexGateway outgoing condition");
   }
 
   public String toString()

Modified: jbossbpm/spec/trunk/modules/ri/src/main/java/org/jboss/bpm/model/internal/EventBuilderImpl.java
===================================================================
--- jbossbpm/spec/trunk/modules/ri/src/main/java/org/jboss/bpm/model/internal/EventBuilderImpl.java	2008-08-15 14:49:51 UTC (rev 1906)
+++ jbossbpm/spec/trunk/modules/ri/src/main/java/org/jboss/bpm/model/internal/EventBuilderImpl.java	2008-08-16 09:20:28 UTC (rev 1907)
@@ -24,8 +24,10 @@
 //$Id$
 
 import org.jboss.bpm.NotImplementedException;
+import org.jboss.bpm.model.EndEvent;
 import org.jboss.bpm.model.Event;
 import org.jboss.bpm.model.EventBuilder;
+import org.jboss.bpm.model.IntermediateEvent;
 import org.jboss.bpm.model.Signal;
 import org.jboss.bpm.model.StartEvent;
 import org.jboss.bpm.model.Signal.SignalType;
@@ -52,9 +54,17 @@
       Signal signal = new Signal(event.getName(), signalType, message);
       start.addTrigger(new SignalEventDetailImpl(signal));
     }
+    else if (event instanceof IntermediateEvent)
+    {
+      throw new NotImplementedException("JBPM-1650", "IntermediateEvent SignalTrigger");
+    }
+    else if (event instanceof EndEvent)
+    {
+      throw new NotImplementedException("JBPM-1651", "EndEvent SignalTrigger");
+    }
     else
     {
-      throw new NotImplementedException("Trigger on: " + event);
+      throw new IllegalStateException("Trigger on: " + event);
     }
     return this;
   }

Modified: jbossbpm/spec/trunk/modules/ri/src/main/java/org/jboss/bpm/model/internal/ExclusiveGatewayDataBasedImpl.java
===================================================================
--- jbossbpm/spec/trunk/modules/ri/src/main/java/org/jboss/bpm/model/internal/ExclusiveGatewayDataBasedImpl.java	2008-08-15 14:49:51 UTC (rev 1906)
+++ jbossbpm/spec/trunk/modules/ri/src/main/java/org/jboss/bpm/model/internal/ExclusiveGatewayDataBasedImpl.java	2008-08-16 09:20:28 UTC (rev 1907)
@@ -23,9 +23,7 @@
 
 //$Id$
 
-import org.jboss.bpm.NotImplementedException;
 import org.jboss.bpm.model.ExclusiveGatewayDataBased;
-import org.jboss.bpm.model.Gate;
 
 /**
  * A point in the workflow process where, based on a decision or workflow control data, one of several branches is chosen. 
@@ -46,12 +44,6 @@
     return ExclusiveType.Data;
   }
 
-  public Gate getDefaultGate()
-  {
-    
-    throw new NotImplementedException();
-  }
-  
   public String toString()
   {
     return "ExclusiveGateway[" + getName() + "]";

Modified: jbossbpm/spec/trunk/modules/ri/src/main/java/org/jboss/bpm/model/internal/GateImpl.java
===================================================================
--- jbossbpm/spec/trunk/modules/ri/src/main/java/org/jboss/bpm/model/internal/GateImpl.java	2008-08-15 14:49:51 UTC (rev 1906)
+++ jbossbpm/spec/trunk/modules/ri/src/main/java/org/jboss/bpm/model/internal/GateImpl.java	2008-08-16 09:20:28 UTC (rev 1907)
@@ -61,7 +61,7 @@
   
   public List<Assignment> getAssignments()
   {
-    throw new NotImplementedException();
+    throw new NotImplementedException("JBPM-1641", "Gate Assignments");
   }
   
   public String toString()

Modified: jbossbpm/spec/trunk/modules/ri/src/main/java/org/jboss/bpm/model/internal/HandlerImpl.java
===================================================================
--- jbossbpm/spec/trunk/modules/ri/src/main/java/org/jboss/bpm/model/internal/HandlerImpl.java	2008-08-15 14:49:51 UTC (rev 1906)
+++ jbossbpm/spec/trunk/modules/ri/src/main/java/org/jboss/bpm/model/internal/HandlerImpl.java	2008-08-16 09:20:28 UTC (rev 1907)
@@ -27,7 +27,7 @@
 import org.jboss.bpm.runtime.Handler;
 
 /**
- * Implement to handle the outgoing Flows for an FlowObject
+ * Base implementation of all handlers
  * 
  * @author thomas.diesler at jboss.com
  * @since 08-Jul-2008
@@ -70,7 +70,7 @@
       }
       else if (beanRef != null)
       {
-        throw new NotImplementedException();
+        throw new NotImplementedException("JBPM-1642", "Handler BeanRef");
       }
       else
       {

Modified: jbossbpm/spec/trunk/modules/ri/src/main/java/org/jboss/bpm/model/internal/MessageFlowImpl.java
===================================================================
--- jbossbpm/spec/trunk/modules/ri/src/main/java/org/jboss/bpm/model/internal/MessageFlowImpl.java	2008-08-15 14:49:51 UTC (rev 1906)
+++ jbossbpm/spec/trunk/modules/ri/src/main/java/org/jboss/bpm/model/internal/MessageFlowImpl.java	2008-08-16 09:20:28 UTC (rev 1907)
@@ -24,7 +24,6 @@
 //$Id$
 
 import org.jboss.bpm.NotImplementedException;
-import org.jboss.bpm.model.GraphicalElement;
 import org.jboss.bpm.model.Message;
 import org.jboss.bpm.model.MessageFlow;
 
@@ -38,7 +37,6 @@
 @SuppressWarnings("serial")
 public class MessageFlowImpl extends FlowImpl implements MessageFlow
 {
-
   public MessageFlowImpl(String targetName)
   {
     super(targetName);
@@ -46,16 +44,6 @@
 
   public Message getMessageRef()
   {
-    throw new NotImplementedException();
+    throw new NotImplementedException("JBPM-1382", "MessageFlow");
   }
-
-  public GraphicalElement getSourceRef()
-  {
-    throw new NotImplementedException();
-  }
-
-  public GraphicalElement getTargetRef()
-  {
-    throw new NotImplementedException();
-  }
 }
\ No newline at end of file

Modified: jbossbpm/spec/trunk/modules/ri/src/main/java/org/jboss/bpm/model/internal/ProcessBuilderImpl.java
===================================================================
--- jbossbpm/spec/trunk/modules/ri/src/main/java/org/jboss/bpm/model/internal/ProcessBuilderImpl.java	2008-08-15 14:49:51 UTC (rev 1906)
+++ jbossbpm/spec/trunk/modules/ri/src/main/java/org/jboss/bpm/model/internal/ProcessBuilderImpl.java	2008-08-16 09:20:28 UTC (rev 1907)
@@ -174,6 +174,10 @@
       {
         flowObject = new NoneTaskImpl(name);
       }
+      else if (type == TaskType.Service)
+      {
+        throw new NotImplementedException("JBPM-1652", "Task Type Service");
+      }
       else if (type == TaskType.Receive)
       {
         flowObject = new ReceiveTaskImpl(name);
@@ -182,9 +186,25 @@
       {
         flowObject = new SendTaskImpl(name);
       }
+      else if (type == TaskType.User)
+      {
+        throw new NotImplementedException("JBPM-1653", "Task Type User");
+      }
+      else if (type == TaskType.Script)
+      {
+        throw new NotImplementedException("JBPM-1654", "Task Type Script");
+      }
+      else if (type == TaskType.Manual)
+      {
+        throw new NotImplementedException("JBPM-1655", "Task Type Manual");
+      }
+      else if (type == TaskType.Reference)
+      {
+        throw new NotImplementedException("JBPM-1656", "Task Type Reference");
+      }
       else
       {
-        throw new NotImplementedException("Task type: " + type);
+        throw new IllegalStateException("Task type: " + type);
       }
       addFlowObject(flowObject);
     }

Modified: jbossbpm/spec/trunk/modules/ri/src/main/java/org/jboss/bpm/model/internal/ProcessImpl.java
===================================================================
--- jbossbpm/spec/trunk/modules/ri/src/main/java/org/jboss/bpm/model/internal/ProcessImpl.java	2008-08-15 14:49:51 UTC (rev 1906)
+++ jbossbpm/spec/trunk/modules/ri/src/main/java/org/jboss/bpm/model/internal/ProcessImpl.java	2008-08-16 09:20:28 UTC (rev 1907)
@@ -92,27 +92,27 @@
 
   public List<String> getAssignments()
   {
-    throw new NotImplementedException();
+    throw new NotImplementedException("JBPM-1643", "Process Assignments");
   }
 
   public List<InputSet> getInputSets()
   {
-    throw new NotImplementedException();
+    throw new NotImplementedException("JBPM-1644", "Process InputSets");
   }
 
   public List<OutputSet> getOutputSets()
   {
-    throw new NotImplementedException();
+    throw new NotImplementedException("JBPM-1645", "Process OutputSets");
   }
 
   public List<String> getPerformers()
   {
-    throw new NotImplementedException();
+    throw new NotImplementedException("JBPM-1646", "Process Performers");
   }
 
   public ProcessType getProcessType()
   {
-    throw new NotImplementedException();
+    throw new NotImplementedException("JBPM-1647", "Process Type");
   }
 
   public Property getProperty(String name)

Modified: jbossbpm/spec/trunk/modules/ri/src/main/java/org/jboss/bpm/model/internal/ReceiveTaskImpl.java
===================================================================
--- jbossbpm/spec/trunk/modules/ri/src/main/java/org/jboss/bpm/model/internal/ReceiveTaskImpl.java	2008-08-15 14:49:51 UTC (rev 1906)
+++ jbossbpm/spec/trunk/modules/ri/src/main/java/org/jboss/bpm/model/internal/ReceiveTaskImpl.java	2008-08-16 09:20:28 UTC (rev 1907)
@@ -24,8 +24,6 @@
 import java.util.ArrayList;
 import java.util.List;
 
-import javax.management.ObjectName;
-
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
 import org.jboss.bpm.InvalidProcessException;
@@ -88,14 +86,9 @@
 
   public boolean isInstantiate()
   {
-    throw new NotImplementedException();
+    throw new NotImplementedException("JBPM-1648", "ReceiveTask Instantiate");
   }
 
-  public ObjectName getID()
-  {
-    return getID();
-  }
-
   public void catchMessage(Message message)
   {
     String msgName = message.getName();

Modified: jbossbpm/spec/trunk/modules/ri/src/main/java/org/jboss/bpm/model/internal/TokenExecutorImpl.java
===================================================================
--- jbossbpm/spec/trunk/modules/ri/src/main/java/org/jboss/bpm/model/internal/TokenExecutorImpl.java	2008-08-15 14:49:51 UTC (rev 1906)
+++ jbossbpm/spec/trunk/modules/ri/src/main/java/org/jboss/bpm/model/internal/TokenExecutorImpl.java	2008-08-16 09:20:28 UTC (rev 1907)
@@ -140,6 +140,6 @@
 
   public Token activate(String tokenID)
   {
-    throw new NotImplementedException();
+    throw new NotImplementedException("JBPM-1649", "Token Activate");
   }
 }
\ No newline at end of file

Modified: jbossbpm/spec/trunk/modules/samples/airticket/server/src/main/java/org/jboss/bpm/samples/airticket/server/AirticketServiceImpl.java
===================================================================
--- jbossbpm/spec/trunk/modules/samples/airticket/server/src/main/java/org/jboss/bpm/samples/airticket/server/AirticketServiceImpl.java	2008-08-15 14:49:51 UTC (rev 1906)
+++ jbossbpm/spec/trunk/modules/samples/airticket/server/src/main/java/org/jboss/bpm/samples/airticket/server/AirticketServiceImpl.java	2008-08-16 09:20:28 UTC (rev 1907)
@@ -6,7 +6,6 @@
 import javax.management.ObjectName;
 import javax.servlet.http.HttpSession;
 
-import org.jboss.bpm.NotImplementedException;
 import org.jboss.bpm.client.MessageListener;
 import org.jboss.bpm.client.MessageManager;
 import org.jboss.bpm.client.ObjectNameFactory;
@@ -81,7 +80,7 @@
     }
     else
     {
-      throw new NotImplementedException(gwtMsg.getClass().getName());
+      throw new IllegalStateException(gwtMsg.getClass().getName());
     }
   }
 
@@ -140,7 +139,7 @@
       }
       else
       {
-        throw new NotImplementedException(msgName);
+        throw new IllegalStateException(msgName);
       }
     }
     return returnMsg;




More information about the jbpm-commits mailing list