[jbpm-commits] JBoss JBPM SVN: r3014 - in projects/gwt-console/trunk/war/src/main/java/org/jboss/bpm/console/client: process and 1 other directory.

do-not-reply at jboss.org do-not-reply at jboss.org
Thu Nov 20 09:29:47 EST 2008


Author: heiko.braun at jboss.com
Date: 2008-11-20 09:29:46 -0500 (Thu, 20 Nov 2008)
New Revision: 3014

Modified:
   projects/gwt-console/trunk/war/src/main/java/org/jboss/bpm/console/client/MainView.java
   projects/gwt-console/trunk/war/src/main/java/org/jboss/bpm/console/client/process/ProcessDefinitionList.java
   projects/gwt-console/trunk/war/src/main/java/org/jboss/bpm/console/client/process/ProcessInstanceList.java
Log:
Cleanup logging

Modified: projects/gwt-console/trunk/war/src/main/java/org/jboss/bpm/console/client/MainView.java
===================================================================
--- projects/gwt-console/trunk/war/src/main/java/org/jboss/bpm/console/client/MainView.java	2008-11-20 14:24:56 UTC (rev 3013)
+++ projects/gwt-console/trunk/war/src/main/java/org/jboss/bpm/console/client/MainView.java	2008-11-20 14:29:46 UTC (rev 3014)
@@ -21,6 +21,7 @@
  */
 package org.jboss.bpm.console.client;
 
+import com.allen_sauer.gwt.log.client.Log;
 import com.google.gwt.core.client.GWT;
 import com.google.gwt.http.client.Request;
 import com.google.gwt.http.client.Response;
@@ -37,7 +38,6 @@
 import com.gwtext.client.widgets.layout.BorderLayoutData;
 import com.gwtext.client.widgets.layout.FitLayout;
 import com.gwtext.client.widgets.layout.VerticalLayout;
-import com.allen_sauer.gwt.log.client.Log;
 import org.jboss.bpm.console.client.metric.MetricOverviewEditor;
 import org.jboss.bpm.console.client.process.ProcessDefinitionListEditor;
 import org.jboss.bpm.console.client.task.TaskListEditor;
@@ -225,18 +225,13 @@
       return this.urlBuilder;
    }
 
-   public void setError(final String error)
-   {
-      displayMessage(error, true);
-   }
-
    public void displayMessage(final String message, final boolean isError)
    {
       status.setText(message);
 
       MessageBox.show(new MessageBoxConfig() {
          {
-            String title = isError ? "Unknown error" : "System Message";
+            String title = isError ? "Error" : "System Message";
             setTitle(title);
             setMsg(message);
             setButtons(MessageBox.OK);

Modified: projects/gwt-console/trunk/war/src/main/java/org/jboss/bpm/console/client/process/ProcessDefinitionList.java
===================================================================
--- projects/gwt-console/trunk/war/src/main/java/org/jboss/bpm/console/client/process/ProcessDefinitionList.java	2008-11-20 14:24:56 UTC (rev 3013)
+++ projects/gwt-console/trunk/war/src/main/java/org/jboss/bpm/console/client/process/ProcessDefinitionList.java	2008-11-20 14:29:46 UTC (rev 3014)
@@ -131,8 +131,7 @@
                      }
                      catch (RequestException e1)
                      {
-                        view.setError(e1.getMessage());
-                        e1.printStackTrace();
+                        Log.error("Request failed", e1);                        
                      }
                   }
                }

Modified: projects/gwt-console/trunk/war/src/main/java/org/jboss/bpm/console/client/process/ProcessInstanceList.java
===================================================================
--- projects/gwt-console/trunk/war/src/main/java/org/jboss/bpm/console/client/process/ProcessInstanceList.java	2008-11-20 14:24:56 UTC (rev 3013)
+++ projects/gwt-console/trunk/war/src/main/java/org/jboss/bpm/console/client/process/ProcessInstanceList.java	2008-11-20 14:29:46 UTC (rev 3014)
@@ -101,14 +101,13 @@
                              public void onError(Request request, Throwable t)
                              {
                                 // auth failed
-                                Log.error("Failed to remove process instance: "+t.getMessage());                                
+                                Log.error("Failed to remove process instance", t);                                
                              }
                           });
                      }
                      catch (RequestException e1)
                      {
-                        view.setError(e1.getMessage());
-                        e1.printStackTrace();
+                        Log.error("Request failed", e1);                        
                      }
                   }
                }
@@ -153,8 +152,7 @@
                      }
                      catch (RequestException e1)
                      {
-                        view.setError(e1.getMessage());
-                        e1.printStackTrace();
+                        Log.error("Request failed", e1);                        
                      }
                   }
                }




More information about the jbpm-commits mailing list