[jbpm-commits] JBoss JBPM SVN: r4092 - in jbpm3/branches/jbpm-3.2.6.GA/modules/core/src: test/java/org/jbpm and 1 other directory.

[do-not-reply at jboss.org]

Author: thomas.diesler at jboss.com
Date: 2009-02-28 18:38:45 -0500 (Sat, 28 Feb 2009)
New Revision: 4092

Modified:
   jbpm3/branches/jbpm-3.2.6.GA/modules/core/src/main/java/org/jbpm/JbpmConfiguration.java
   jbpm3/branches/jbpm-3.2.6.GA/modules/core/src/main/java/org/jbpm/JbpmContext.java
   jbpm3/branches/jbpm-3.2.6.GA/modules/core/src/test/java/org/jbpm/JbpmConfigurationTest.java
Log:
[JBPM-2074] Removed invalid usage of finalize

Modified: jbpm3/branches/jbpm-3.2.6.GA/modules/core/src/main/java/org/jbpm/JbpmConfiguration.java
===================================================================
--- jbpm3/branches/jbpm-3.2.6.GA/modules/core/src/main/java/org/jbpm/JbpmConfiguration.java	2009-02-28 23:11:26 UTC (rev 4091)
+++ jbpm3/branches/jbpm-3.2.6.GA/modules/core/src/main/java/org/jbpm/JbpmConfiguration.java	2009-02-28 23:38:45 UTC (rev 4092)
@@ -619,12 +619,6 @@
     }
   }
 
-  @Override
-  protected void finalize() throws Throwable
-  {
-    close();
-  }
-
   static JbpmConfiguration getCurrentJbpmConfiguration()
   {
     JbpmConfiguration currentJbpmConfiguration = null;

Modified: jbpm3/branches/jbpm-3.2.6.GA/modules/core/src/main/java/org/jbpm/JbpmContext.java
===================================================================
--- jbpm3/branches/jbpm-3.2.6.GA/modules/core/src/main/java/org/jbpm/JbpmContext.java	2009-02-28 23:11:26 UTC (rev 4091)
+++ jbpm3/branches/jbpm-3.2.6.GA/modules/core/src/main/java/org/jbpm/JbpmContext.java	2009-02-28 23:38:45 UTC (rev 4092)
@@ -21,7 +21,6 @@
  */
 package org.jbpm;
 
-import java.io.PrintStream;
 import java.io.Serializable;
 import java.sql.Connection;
 import java.util.ArrayList;
@@ -111,17 +110,10 @@
   public JbpmContext(Services services, ObjectFactory objectFactory)
   {
     log.debug("creating " + toString());
-    
-    if (logCreateStackTrace)
-      new RuntimeException().printStackTrace(new PrintStream(System.out));
-    
     this.services = services;
     this.objectFactory = objectFactory;
   }
   
-  // [JBPM-2074] Fix intermittent problem with JbpmConfigurationTest.testDomainModelConfigsWithoutJbpmContext
-  public static boolean logCreateStackTrace;
-
   /**
    * make sure you close your JbpmContext in a finally block.
    */

Modified: jbpm3/branches/jbpm-3.2.6.GA/modules/core/src/test/java/org/jbpm/JbpmConfigurationTest.java
===================================================================
--- jbpm3/branches/jbpm-3.2.6.GA/modules/core/src/test/java/org/jbpm/JbpmConfigurationTest.java	2009-02-28 23:11:26 UTC (rev 4091)
+++ jbpm3/branches/jbpm-3.2.6.GA/modules/core/src/test/java/org/jbpm/JbpmConfigurationTest.java	2009-02-28 23:38:45 UTC (rev 4092)
@@ -128,19 +128,11 @@
     // 'jbpm.cfg.xml' or the static method JbpmConfiguration.Configs.setDefaultObjectFactory
     // to specify the configuration information.
 
-    JbpmContext.logCreateStackTrace = true;
-    try
-    {
-      JbpmConfiguration.Configs.setDefaultObjectFactory(ObjectFactoryParser.parseXmlString(
-          "<jbpm-configuration>" + 
-          "  <string name='myproperty'>myvalue</string>" + 
-          "</jbpm-configuration>"));
-      assertEquals("myvalue", JbpmConfiguration.Configs.getString("myproperty"));
-    }
-    finally
-    {
-      JbpmContext.logCreateStackTrace = false;
-    }
+    JbpmConfiguration.Configs.setDefaultObjectFactory(ObjectFactoryParser.parseXmlString(
+        "<jbpm-configuration>" + 
+        "  <string name='myproperty'>myvalue</string>" + 
+        "</jbpm-configuration>"));
+    assertEquals("myvalue", JbpmConfiguration.Configs.getString("myproperty"));
   }
 
   public static class CustomObjectFactory implements ObjectFactory