[jopr-issues] [JBoss JIRA] Commented: (JOPR-108) Add support for local-tx connection factories

[Ian Springer (JIRA)]

    [ https://jira.jboss.org/jira/browse/JOPR-108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12458457#action_12458457 ] 

Ian Springer commented on JOPR-108:
-----------------------------------

It looks like there may be more of an issue here than just a missing type in the enum.

In the JBAS 5.x source, I see:

  https://anonsvn.jboss.org/repos/jbossas/branches/Branch_5_x/connector/src/main/org/jboss/resource/metadata/mcf/TxConnectionFactoryDeploymentMetaData.java

which defines the @ManagementComponent(type="ConnectionFactory",subtype="XA") componentType.

and:

  https://anonsvn.jboss.org/repos/jbossas/branches/Branch_5_x/connector/src/main/org/jboss/resource/metadata/mcf/NoTxConnectionFactoryDeploymentMetaData.java

which defines the @ManagementComponent(type="ConnectionFactory",subtype="NoTx") componentType.

But I do -not- see anything which defines the @ManagementComponent(type="ConnectionFactory",subtype="LocalTx") componentType.

I see:

  https://anonsvn.jboss.org/repos/jbossas/branches/Branch_5_x/connector/src/main/org/jboss/resource/metadata/mcf/ManagedConnectionFactoryDeploymentMetaData.java

but that appears to just be a base class for the specific CF types.

Scott, can you comment?


> Add support for local-tx connection factories
> ---------------------------------------------
>
>                 Key: JOPR-108
>                 URL: https://jira.jboss.org/jira/browse/JOPR-108
>             Project: Jopr
>          Issue Type: Feature Request
>          Components: Plugin - JBoss AS 5
>    Affects Versions: 2.1
>            Reporter: Ian Springer
>            Assignee: Ian Springer
>             Fix For: 2.2
>
>
> We have support for XA and no-tx ones, we should add local-tx. This page describes the different varieties:
>     http://www.jboss.org/community/docs/DOC-9326
> I based the Resource types I exposed off of the ConnectionFactoryTypes enum from org.jboss.deployers.spi.management.KnownComponentTypes:
>    /**
>     * Enums for generic ConnectionFactory types
>     */
>    public enum ConnectionFactoryTypes
>    {
>       XA("ConnectionFactory", "XA"), NoTx("ConnectionFactory", "NoTx");
>       private final String type;
>       private final String subtype;
>       private ConnectionFactoryTypes(String type, String subtype)
>       {
>          this.type = type;
>          this.subtype = subtype;
>       }
>       public String type()
>       {
>          return type;
>       }
>       public String subtype()
>       {
>          return subtype;
>       }
>       public ComponentType getType()
>       {
>          return new ComponentType(type, subtype);
>       }
>    };
> If there is also a LocalTX type, then this enum should be updated. A JBAS issue has been created for Scott to review the KnownComponentTypes enums:
>      https://jira.jboss.org/jira/browse/JBAS-6646

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira