[jsr-314-open-mirror] [jsr-314-open] Fwd: Fix UIData state saving model

[Ed Burns]

>>>>> On Thu, 26 Aug 2010 16:23:25 -0500, Leonardo Uribe <lu4242 at gmail.com> said:

LU> Hi
LU> I attached a patch with better documentation for TransientStateHelper -
LU> TransientStateHolder and the answers requested. If you need anything
LU> else just let me know and I'll do it.

Thank you.  I'll work in the content of your revised patch.  Also, I
can't say enough how great the test app is.  Very thorough.  It'll fit
right into our automated test library.

Leonardo, I'll need you to fill out and submit the necessary
documentation for the Joint Copyright Assignment so that both you and
the JSR sponsor (Oracle) can jointly own the copyright on the code.

Get this PDF <http://oss.oracle.com/oca.pdf>, print it out, fill it out
with pen, scan it, and email it to me directly.  This is necessary to
take the patch, and it is also necessary if you want to get commit
access eventually.

LU>  I resume the comments below:

Ok, I'll work this content into the spec language.

[...]

LU> To include the patch in jsf 2.1, we need to resolve the following point
LU> left:

LU> - On UIData.markInitialState do not use a facesContext attribute
LU> "com.sun.faces.MARK_INITIAL_STATE", instead it could be better to use
LU> a variable on FacesContext to indicate when we are marking the initial
LU> state,
LU> like FacesContext.isProcessingEvents() works.

We can do that if you like, but it's just syntatic sugar IMHO.  I prefer
to just introduce constants rather than methods.  Would you be ok if we
made it an official "javax.faces.MARK_INITIAL_STATE" attribute?

Ed

-- 
| edward.burns at oracle.com | office: +1 407 458 0017
| homepage:               | http://ridingthecrest.com/
| 11 work days until JSF 2.1 Milestone 3