[jsr-314-open-mirror] [jsr-314-open] UIComponent.invokeOnComponent does not call pushComponentToEL() and popComponentFromEL()
Ed Burns
edward.burns at oracle.com
Tue Oct 19 22:47:13 EDT 2010
>>>>> On Tue, 19 Oct 2010 09:30:01 -0700, Ed Burns <edward.burns at oracle.com> said:
>>>>> On Mon, 18 Oct 2010 17:02:32 -0700, Blake Sullivan <blake.sullivan at oracle.com> said:
B> I definitely consider it a bug for the reason you mention. All of the
B> Trinidad components do push and pop the EL context during
B> invokeOnComponent. I believe that tree visiting does establish the
B> context correctly, which also shows where the intent lies.
EB> I agree this is probably a bug. I have made the change and am
EB> re-running our automated test suite. If there are no errors, I'll take
EB> the liberty of modifying the spec and impl, attaching a patch, seeking
EB> review, and commiting it. I think this can reasonably be grandfathered
EB> in under existing JSF 2.1 changelog issue 868. [1]
I have attached the diffs to the issue. I would appreciate a quick code
review of attachment 310 on [1], but considering that it is a small
change, I'll commit it ahead of the review.
Note that I modified the automated tests as well.
Ed
[1] https://javaserverfaces-spec-public.dev.java.net/issues/show_bug.cgi?id=868
--
| edward.burns at oracle.com | office: +1 407 458 0017
| homepage: | http://ridingthecrest.com/
| 16 work days until German Oracle User's Group Conference
More information about the jsr-314-open-mirror
mailing list