[keycloak-dev] Feedback on examples

[Bill Burke]

On 12/10/2013 11:45 AM, Marek Posolda wrote:
> I have few points regarding example applications:
>
> - For third-party oauth client example, there is not possibility to
> configure stuff through JSON but everything is hardcoded in classes
> Bootstrap and ProductDatabaseClient. There are also some strange
> comments in code like "This is the worst code ever" etc :-) This is not
> so ideal IMO as I expect that people will often look to the source code
> of these examples for inspiration. I believe that OAuth clients should
> also have something like ManagedResourceConfigLoader for Applications.
>

Feel free to write a better example with CDI or Spring and expand out 
the oauth client framework code.

> - For the "third-party" OAuth client, I don't like the fact that when
> user press "Cancel" in OAuth grant page, there is exception in
> server.log and Tomcat error page displayed. I believe the behaviour
> should be more user-friendly.
>

Again, feel free to expand on the third-party app to display something 
better.

> - Examples "customer-portal", "product-portal", "database-service" and
> "oauth-client" are using package "org.jboss.reasteasy..." instead of
> "org.keycloak..."
>

Yeah, holdover from Resteasy code I migrated from.


-- 
Bill Burke
JBoss, a division of Red Hat
http://bill.burkecentral.com