[keycloak-dev] Feedback on examples

[Marek Posolda]

On 11.12.2013 14:10, Bill Burke wrote:
> On 12/10/2013 11:45 AM, Marek Posolda wrote:
>> >I have few points regarding example applications:
>> >
>> >- For third-party oauth client example, there is not possibility to
>> >configure stuff through JSON but everything is hardcoded in classes
>> >Bootstrap and ProductDatabaseClient. There are also some strange
>> >comments in code like "This is the worst code ever" etc:-)  This is not
>> >so ideal IMO as I expect that people will often look to the source code
>> >of these examples for inspiration. I believe that OAuth clients should
>> >also have something like ManagedResourceConfigLoader for Applications.
>> >
> Feel free to write a better example with CDI or Spring and expand out
> the oauth client framework code.
>
>> >- For the "third-party" OAuth client, I don't like the fact that when
>> >user press "Cancel" in OAuth grant page, there is exception in
>> >server.log and Tomcat error page displayed. I believe the behaviour
>> >should be more user-friendly.
>> >
> Again, feel free to expand on the third-party app to display something
> better.
>
Just a note that I've updated PR 
https://github.com/keycloak/keycloak/pull/134 and synced it with your 
latest adapter changes. Not sure if you received github notifications, 
so writing here just in case:-)
For now, I changed just third-party application in 
examples/as7-eap-demo/third-party to use CDI. I can update wildfly 
example as well if you are ok with my impl.

Marek