[keycloak-dev] Refactoring to KeycloakSession and ProviderSession

[Stian Thorgersen]

----- Original Message -----
> From: "Bill Burke" <bburke at redhat.com>
> To: keycloak-dev at lists.jboss.org
> Sent: Monday, 30 June, 2014 5:25:31 PM
> Subject: Re: [keycloak-dev] Refactoring to KeycloakSession and	ProviderSession
> 
> Ugh...Why?  Would have been cool to discuss this before you did this.
> There was a clear separation of things prior to this change:
> 
> * ProviderSession was for resolving various session based APIs I thought.
> * KeycloakSession was analogous to EntityManager or HibernateSession.

I didn't really think it was a big deal, as the separation is still there. What used to be KeycloakSession is now ModelProvider, and the new KeycloakSession is just a wrapper to be able to get to both from the same @Context injection.

> 
> Also, you don't go committing stuff that breaks existing code...i.e. the
> caching stuff I did.

I commented out the cache stuff as it wasn't working, see https://issues.jboss.org/browse/KEYCLOAK-527. I tried to fix it, but couldn't quite figure out how to go about doing it, so thought it was best to disable it until you got back and could have a look. I was going to send you an email about it, but of course I forgot that :(

> 
> 
> On 6/27/2014 4:56 AM, Stian Thorgersen wrote:
> > I've combined KeycloakSession and ProviderSession into KeycloakSession.
> > There's a single implementation of this (DefaultKeycloakSession).
> >
> > Model implementations now implement ModelProvider instead of
> > KeycloakSession.
> > _______________________________________________
> > keycloak-dev mailing list
> > keycloak-dev at lists.jboss.org
> > https://lists.jboss.org/mailman/listinfo/keycloak-dev
> >
> 
> --
> Bill Burke
> JBoss, a division of Red Hat
> http://bill.burkecentral.com
> _______________________________________________
> keycloak-dev mailing list
> keycloak-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/keycloak-dev
>