[keycloak-dev] Rename WildFly subsystem

Stian Thorgersen stian at redhat.com
Mon Nov 24 03:36:16 EST 2014


I'd say go ahead and rename, but add a note in the migration docs

----- Original Message -----
> From: "Stan Silvert" <ssilvert at redhat.com>
> To: keycloak-dev at lists.jboss.org
> Sent: Monday, 24 November, 2014 1:57:28 AM
> Subject: Re: [keycloak-dev] Rename WildFly subsystem
> 
> On 11/21/2014 3:24 PM, Bill Burke wrote:
> > This is the adapter?  How can you merge the two when one uses undertow
> > and the other uses jbossweb?
> I load a different dependency processor and deployment processor
> depending on the platform.  Other than that, the rest of the subsystem
> can share a common code base.
> https://github.com/ssilvert/keycloak/compare/eap-subsys#diff-c93f72cc7e2e48f1803b7b82436fbb64L51
> 
> >
> >
> >
> > On 11/21/2014 1:49 PM, Stan Silvert wrote:
> >> I've merged the code bases so that we just have a single subsystem for
> >> both WildFly and EAP/AS7.  Working great on both (yay!).
> >>
> >> So the EAP subsystem will be removed from the code base and I now just
> >> have the WildFly subsystem that works for both.
> >>
> >> Can anyone think of a reason why I shouldn't rename this to
> >> "keycloak-subsystem" instead of "keycloak-wildfly-subsystem"?  The only
> >> problem I can think of is that it will break existing user's
> >> standalone.xml files that refer to the old name.||
> >>
> >>
> >> _______________________________________________
> >> keycloak-dev mailing list
> >> keycloak-dev at lists.jboss.org
> >> https://lists.jboss.org/mailman/listinfo/keycloak-dev
> >>
> 
> _______________________________________________
> keycloak-dev mailing list
> keycloak-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/keycloak-dev
> 


More information about the keycloak-dev mailing list