[keycloak-dev] tomcat 7 adapter

[Bill Burke]

Its not a perfect match.  Constructors are different in a few classes too :(

On 10/30/2014 4:05 AM, Marek Posolda wrote:
> Great, however the fact that Tomcat7 adapter is defacto copy/paste of
> AS7 adapter means that every change needs to be done on 2 places.
>
> I wonder if we can try to create some common "jboss-web" module and then
> tomcat7 and jboss7 specific submodules? Those will handle just specific
> differences among AS7 and Tomcat7
> (For example common project will have simple logging abstraction, which
> will delegate to jboss-logging on AS7 or JDK-logging on Tomcat, The
> differences for establish security context on
> CatalinaSecurityContextHelper will be always abstractized etc)
>
> There are differences in dependencies, but class-names are the same (For
> example org.apache.catalina.authenticator.FormAuthenticator has same
> name and package in both tomcat and jboss-web dependency), so I believe
> that it's not a problem to compile common project against jboss-web and
> then use runtime dependency on tomcat-catalina (For Tomcat7 environment)?
>
> I am not sure myself if it's way to go, maybe it's just over-simplifying
> as the code is not big anyway. Just possible idea to think about;-)
>
> Marek
>
> On 29.10.2014 19:49, Bill Burke wrote:
>> I added the tomcat 7 adapter to the distro as well as some docbook docs
>> for it.  This is shaping up to a really nice release!
>>
>>
>

-- 
Bill Burke
JBoss, a division of Red Hat
http://bill.burkecentral.com