[keycloak-dev] Upgrade Angular?

[Stian Thorgersen]

----- Original Message -----
> From: "Stan Silvert" <ssilvert at redhat.com>
> To: "Stian Thorgersen" <stian at redhat.com>
> Cc: keycloak-dev at lists.jboss.org
> Sent: Wednesday, 19 August, 2015 3:19:24 PM
> Subject: Re: [keycloak-dev] Upgrade Angular?
> 
> On 8/19/2015 9:07 AM, Stian Thorgersen wrote:
> >
> > ----- Original Message -----
> >> From: "Stan Silvert" <ssilvert at redhat.com>
> >> To: "Stian Thorgersen" <stian at redhat.com>
> >> Cc: keycloak-dev at lists.jboss.org
> >> Sent: Wednesday, 19 August, 2015 2:28:04 PM
> >> Subject: Re: [keycloak-dev] Upgrade Angular?
> >>
> >> On 8/19/2015 2:11 AM, Stian Thorgersen wrote:
> >>> I'm not aware of any reasons we can't upgrade, but we would need to take
> >>> care and do extra testing of the admin console afterwards.
> >>>
> >>> I'd prefer to upgrade to 1.4.4 early in a Sprint, so if you can upgrade
> >>> this week, that's fine. Otherwise I'd like to wait to 1.6 release cycle.
> >> I think we should wait until a fresh sprint.
> >>
> >> We may need a Sprint that is partially or fully dedicated to the UI.
> >> It's going to be a big job to go through the UI and replace every bit of
> >> static text and static message with an angular-translate lookup.   As
> >> you suggested, it probably makes sense to divide that work up among the
> >> team members.
> >>
> >> When we do that, we should also upgrade Angular.  That way, everyone is
> >> covering the full UI to make sure that everything is localized and every
> >> part works properly with Angular 1.4.x.
> >>
> >> Sound like a good plan?
> > I'd say upgrading to Angular 1.4.x should be done first. If there's any
> > issues with it it will be much easier to resolve them without also having
> > the localization to deal with. Ideally we should do that this week and
> > include for 1.5. Upgrading to 1.4.x could break everything/nothing, but
> > it's hard to know what parts could be affected, that's why it requires a
> > full test of the admin console.
> >
> > Internationalization would only affect the page that you edit, so whoever
> > updates a page to also verify that it works. It can also be incremental,
> > we don't have to internationalize the whole console in one sprint.
> >
> > We should:
> >
> > a) Upgrade to 1.4.x - test all functionality in the console
> > b) Add internationalization of a few pages
> > c) Make sure internationalization works as expected
> > d) Internationalize all pages
> >
> > Ideally I'd like a-c included in 1.5.
> BTW, I agree that we should do b and c in 1.5.  I'm just worried about a.
> 
> d doesn't necessarily have to be done in one sprint, but it seems to be
> a good way to make sure we have full coverage in testing the Angular
> upgrade.

a) has to be done first - if you upgrade it, test it to as much as you can, then either me or someone else does a full round of testing as well. Once a is done you can start adding b.

We always do a more or less full test of the admin console before releasing as we don't have any automated tests for it yet, but as upgrading AngularJS could introduce a lot of changes I want the testing done early and any issues resolved prior to internationalization added. I don't want to end up in a situation where we identity issues during last tests for the release and then we don't know if it's broken due to AngularJS or internationalization.


> >
> >>> ----- Original Message -----
> >>>> From: "Stan Silvert" <ssilvert at redhat.com>
> >>>> To: keycloak-dev at lists.jboss.org
> >>>> Sent: Tuesday, 18 August, 2015 9:59:47 PM
> >>>> Subject: [keycloak-dev] Upgrade Angular?
> >>>>
> >>>> We are using AngularJS 1.2.13.  The latest version is 1.4.4.
> >>>>
> >>>> The reason I ask is because I am a little worried about performance as
> >>>> we begin to use angular-translate.  We are going to end up with a lot of
> >>>> $$watchers, which will eventually make the UI sluggish.
> >>>>
> >>>> There is a solution starting with Angualr 1.3 that lets you specify a
> >>>> one-time-binding using double colons like this {{ ::value }}.
> >>>>
> >>>> Any reason why we can't upgrade?
> >>>>
> >>>> Stan
> >>>> _______________________________________________
> >>>> keycloak-dev mailing list
> >>>> keycloak-dev at lists.jboss.org
> >>>> https://lists.jboss.org/mailman/listinfo/keycloak-dev
> >>>>
> >>
> 
>