[keycloak-dev] distribution of adapters

[Pedro Igor Silva]

I also agree.

I don't know deeply how adapters are designed, specially how much core is being used to avoid code duplication across different adapters. From what I saw, it seems that most of
the code is provided by core which is a good smell. And only very specific code resides within each adapter, only the necessary bits to get the integration done.

That said, I think most issues will be related with core than with a specific adapter.

----- Original Message -----
From: "Marek Posolda" <mposolda at redhat.com>
To: "Pedro Igor Silva" <psilva at redhat.com>, "Bill Burke" <bburke at redhat.com>
Cc: keycloak-dev at lists.jboss.org
Sent: Thursday, February 19, 2015 3:59:09 PM
Subject: Re: [keycloak-dev] distribution of adapters

I think I agree with Bolek that many separate adapter repos and releases 
is unecessary overhead. Especially if we're going to have even more 
adapter types than we have now...

I can understand for non-maven non-java project, but why have separate 
adapter repo and releases for jetty, tomcat, eap etc? Only advantage is 
possibility to do separate release in case of adapter bug, but not sure 
if it would help much, because there is lot of common code in "core" and 
"adapter-core" . And:

* in case of blocker bug in "core", you need to release whole keycloak 
anyway as this code is shared for both server and adapters
* in case of blocker bug in "adapter-core", you need to release all java 
adapters anyway.

Marek


On 19.2.2015 18:28, Pedro Igor Silva wrote:
> Each adapter in its own repository, right ? And probably an additional one with common stuff ....
>
> ----- Original Message -----
> From: "Bill Burke" <bburke at redhat.com>
> To: keycloak-dev at lists.jboss.org
> Sent: Thursday, February 19, 2015 3:03:56 PM
> Subject: [keycloak-dev] distribution of adapters
>
> I think there is a different here between community and product.
>
> In community:
> * Adapters should each have a separate download.  This has a side effect
> of showing us which adapters are popular (not to mention increasing our
> download numers ;)
> * All adapters are released simultaneously with a server release
> * Adapters can have individual patch releases.
> * If we want to release a patched adapter, use a micro version scheme.
> First 3 numbers correspond to the keycloak version the adapter was built
> against.  Last number is the patch number of the adapter:
>
> We release Keycloak 1.1.0:
> - keycloak-jetty-1.1.0.0
> Werelease a patch of jetty adapter for keycloak 1.1.0
> - keycloak-jetty-1.1.0.1
>
> I'm not sure how all that effects product and git branches.  Ideally
> you'd have matching branches for major keycloak server release for the
> adapter.
>
> i.e.
>
> Keycloak_server_branch_1.1.x
> Keycloak_adapters_branch_1.1.x
>
>