[keycloak-dev] Provider modules

[Stian Thorgersen]

----- Original Message -----
> From: "Bill Burke" <bburke at redhat.com>
> To: keycloak-dev at lists.jboss.org
> Sent: Tuesday, 20 January, 2015 10:35:52 PM
> Subject: Re: [keycloak-dev] Provider modules
> 
> Yo, still working on separation into modules, but...
> 
> Right now, we deploy our JPA plugins via the container deployer as part
> of the WAR.  Not sure if that the deployer will pick up these JPA
> plugins if they are in an imported module.

What's a JPA plugin? We manage everything JPA ourselves so what does it have to do with the deployer?

> 
> On 1/20/2015 12:42 PM, Bill Burke wrote:
> > I'm just saying that editing a module.xml file requires no code changes
> > and we can ship 1.1.
> >
> > Bill
> >
> >
> > On 1/20/2015 12:24 PM, Stan Silvert wrote:
> >>
> >>
> >> ----- Original Message -----
> >> From: "Stian Thorgersen" <stian at redhat.com>
> >> To: "Bill Burke" <bburke at redhat.com>
> >> Cc: keycloak-dev at lists.jboss.org
> >> Sent: Tuesday, January 20, 2015 12:03:59 PM
> >> Subject: Re: [keycloak-dev] Provider modules
> >>
> >>
> >>> Why would you need jboss-deployment-structure.xml to embedded WAR?
> >>
> >>> The problem with that approach is that all providers are loaded from the
> >>> same class-loader so there would be issues if providers use different
> >>> versions of the same library. I also think it would be more natural for
> >>> a WildFly user to edit standalone.xml or use the CLI than to add
> >>> dependencies to an existing module. Finally another issue happens when
> >>> someone upgrades/patches Keycloak, would they not then override the
> >>> keycloak-providers module.xml and have to add everything again?
> >>
> >> Yes they would.  That's another reason why, in general, hacking the WAR
> >> (or anything else we ship) is a bad idea.
> >>
> >> Plus, it drives the support guys absolutely nuts!
> >>
> >
> 
> --
> Bill Burke
> JBoss, a division of Red Hat
> http://bill.burkecentral.com
> _______________________________________________
> keycloak-dev mailing list
> keycloak-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/keycloak-dev
>