[keycloak-dev] 1.2.beta1 planning, need you to defer things

[Bill Burke]

On 3/12/2015 5:51 AM, Stian Thorgersen wrote:
>
>
> ----- Original Message -----
>> From: "Marek Posolda" <mposolda at redhat.com>
>> To: "Stian Thorgersen" <stian at redhat.com>, "Bill Burke" <bburke at redhat.com>
>> Cc: keycloak-dev at lists.jboss.org
>> Sent: Thursday, 12 March, 2015 10:48:53 AM
>> Subject: Re: [keycloak-dev] 1.2.beta1 planning, need you to defer things
>>
>> On 12.3.2015 06:40, Stian Thorgersen wrote:
>>> I'd like to reopen KEYCLOAK-311 as IMO it's not solved. This is not
>>> referring to the claim mapping work you've done, it's something else.
>>>
>>> Before we can do a release we need to make sure that database migration
>>> works (I know they don't atm as social providers and social links are
>>> lost). We also need to add transformation of JSON exports and
>>> representations so older versions can be imported into 1.2.0.Beta1.
>> I did migration of social stuff for Mongo but not for jpa/liquibase
>> though. I guess migration of protocol mappers would be needed too? As in
>> 1.1.0.Final accessToken automatically has all the basic claims like
>> username, email etc. So when people migrate to 1.2.0.Beta1, they would
>> expect the same, which means that default builtin mappers for basic
>> claims will need to be added for all the existing clients?
>
> +1 Can you create a jira so we don't forget?
>

Protocol mappers should already automatically be set up if the user 
exports Keycloak 1.1 json and re-imports it.

>>
>> I have also some fear if export/import would work well together with
>> protocol mappers. During import of previously exported application, the
>> import shouldn't try to add all default mappers, but just those which
>> were previously exported. Currently import invokes
>> realm.addApplication(), which will trigger listeners for adding all
>> default builtin mappers. I did not test it yet, but my bet is that it
>> won't work well atm...
>
> +1 Can you test and jira please?
>

The way it works is:

1. realm.addApplication()
2. builtin mappers installed
3. If application json has mappers, then current mappers are cleared and 
the mappers defined in the json file are used.

I can add a test for this quite easily as I'm already importing json 
with exported mappers.  Doing this right now.

Bill



-- 
Bill Burke
JBoss, a division of Red Hat
http://bill.burkecentral.com