[keycloak-dev] MaxBuffer setting in SamlFilter

[Bill Burke]

log a jira then and we'll get to it sometime when we get back to 2.0 
development.  I can't accept a fix only for one place.

On 4/19/2016 11:02 PM, wadahiro wrote:
> It looks like hard to set it across all adapters because the
> bufferSize is set and used by external dependent library of the SAML
> Adapter except for SamlFilter.
> For example, the bufferSize is used in the Undertow class
> 'io.undertow.servlet.util.SavedRequest' when we use Wildfly SAML
> Adapter as follows.
>
> https://github.com/undertow-io/undertow/blob/1.3.21.Final/servlet/src/main/java/io/undertow/servlet/util/SavedRequest.java#L72
>
> I think the value is read-only and cannot set it from
> 'WildflySamlSessionStore.java' in Wildfly SAML Adapter of Keycloak.
>
> On Tue, Apr 19, 2016 at 10:03 PM, Bill Burke <bburke at redhat.com> wrote:
>> Should be a configuration switch in the keycloak-saml.xml file and set
>> across all adapters.
>>
>> On 4/19/2016 5:00 AM, wadahiro wrote:
>>> Hi,
>>>
>>> I had evaluated Keyloak SAML Client Adapter a month ago.
>>> As a result, I noticed that 'SamlFilter.java' does not support
>>> maxBuffer setting. It was hard-coded with '100000' currently.
>>> I want to propose that we can set it in 'WEB-INF/web.xml', how about
>>> you ? I can send a pull request with the following changes.
>>>
>>> https://github.com/wadahiro/keycloak/commit/0d283caccf5369ae6c48c5530e1a23955f29c64d
>>>
>>> Regards,
>>> Hiroyuki Wada
>>> _______________________________________________
>>> keycloak-dev mailing list
>>> keycloak-dev at lists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/keycloak-dev
>> --
>> Bill Burke
>> JBoss, a division of Red Hat
>> http://bill.burkecentral.com
>>
>> _______________________________________________
>> keycloak-dev mailing list
>> keycloak-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/keycloak-dev
> _______________________________________________
> keycloak-dev mailing list
> keycloak-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/keycloak-dev

-- 
Bill Burke
JBoss, a division of Red Hat
http://bill.burkecentral.com