[keycloak-dev] local build failing, travis passing

[Bill Burke]

These broke because they weren't part of the main build.  I thought they 
were just dead code because when I did a "Find Usages" for them, nothing 
came up.  Minimally, things should at least be compiled with the main 
build, that way when refactorings happen, somebody doesn't delete a test 
dependency by accident.


On 12/5/16 6:53 AM, Hynek Mlnarik wrote:
> Speaking of the tests, we seem not to run any of the adapter test 
> suites. I believe that running at least adapter tests for wildfly 
> would be beneficial, preventing e.g. [1]. WDYT?
>
> [1] https://issues.jboss.org/browse/KEYCLOAK-4017
>
> On Mon, Dec 5, 2016 at 8:39 AM, Marek Posolda <mposolda at redhat.com 
> <mailto:mposolda at redhat.com>> wrote:
>
>     Fyi. On Friday afternoon, I've found the issue that travis didn't run
>     all the tests from the testsuite. And PartialImportTest was the one,
>     which wasn't executed. See
>     https://issues.jboss.org/browse/KEYCLOAK-4021
>     <https://issues.jboss.org/browse/KEYCLOAK-4021>
>
>     However with the travis fix, all the tests were passing (including
>     PartialImportTest). So it seems this test was just failing
>     randomly (not
>     always)?
>
>     Now I can see in latest travis build that PartialImportTest passes.
>
>     Marek
>
>
>
>
>     On 03/12/16 17:36, Bill Burke wrote:
>     > I just noticed that my local build fails while travis passes.
>     The bug is
>     > really something travis should have picked up, specifically the
>     > PartialImportsTest was removing an identity provider.  The JPA
>     > removeIdenittyProviderByAlias method was wrong as it was trying
>     to load
>     > an IdentityProviderModel after it was removed thus resulting in a
>     > Hibernate error.  Travis did not pick this up which makes me
>     wonder if
>     > the test is even running.
>     >
>     > FYI, i have a pull request that fixes this that is incoming. The
>     bug,
>     > not travis.
>     >
>     > Bill
>     >
>     >
>     > _______________________________________________
>     > keycloak-dev mailing list
>     > keycloak-dev at lists.jboss.org <mailto:keycloak-dev at lists.jboss.org>
>     > https://lists.jboss.org/mailman/listinfo/keycloak-dev
>     <https://lists.jboss.org/mailman/listinfo/keycloak-dev>
>
>
>     _______________________________________________
>     keycloak-dev mailing list
>     keycloak-dev at lists.jboss.org <mailto:keycloak-dev at lists.jboss.org>
>     https://lists.jboss.org/mailman/listinfo/keycloak-dev
>     <https://lists.jboss.org/mailman/listinfo/keycloak-dev>
>
>
>
>
> -- 
>
> --Hynek