[keycloak-dev] Need to remove built-in themes from standalone/configuration/themes

[Stan Silvert]

Putting the themes into a module jar raises two usability issues:
1) They have to be extracted and the re-jarred
2) Modules live many, many level deep in the directory structure and are 
therefore hard to find.

I'm not familiar with the limitations of the patching tool, but is seems 
that we could do this:
* Don't put themes in a jar.  Plain files can also live inside a module.
* Create a second module directory structure.  JBoss Modules lets you 
have multiple paths for modules.  So we just have a <KEYCLOAK 
HOMe>/themes path that is a known module path.

The question is, will the patching tool be able to deal with that?  If 
not, we need to fix the patching tool.

On 2/12/2016 9:44 AM, Stian Thorgersen wrote:
>
> Currently we include built-in themes in the themes jar as well as 
> extracted to standalone/configuration/themes. We have to remove the 
> extracted files.
>
> This is due to patching. The patching tools only supports patching 
> modules, not files. If we need to patch the theme templates (quite 
> likely we will) we can then only patch the jar. As the extracted 
> themes override the jar it won't work unless we remove them.
>
> The main problem with removing the extracted files is that they are 
> useful for someone that needs to modify the templates. I think the 
> best would just be to give people instructions on how to extract these 
> from the jar. It's just a zip after all.
>
> Thoughts??
>
>
>
> _______________________________________________
> keycloak-dev mailing list
> keycloak-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/keycloak-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/keycloak-dev/attachments/20160212/1774728b/attachment.html