[keycloak-dev] need explanation of distribution for adapters

[Stian Thorgersen]

True, didn't consider that. We could do it with Infinispan because the
methods where actually there, just didn't work on the old version.

I can't see any other option then. Sucks to have to maintain all this
different versions of the adapters.

On 21 January 2016 at 20:27, Bill Burke <bburke at redhat.com> wrote:

> You still have to have different jars as how would Wildfly9Impl and
> Wildfly10Impl compile?  Again, the type parameters used in Wildfly9 don't
> exist in 10.  The ones used in 10 don't exist in 9.
>
>
> On 1/21/2016 2:19 PM, Stian Thorgersen wrote:
>
> What I mean is:
>
> if
> (TheProblemClass.class.getMethod("..").getParameterTypes()[0].equals(SomeObject.class))
> {
>   return new WildFly9Impl();
> } else {
>   return new WildFly10Impl();
> }
>
> Is that not simpler and easier for users than creating a whole new adapter
> dist?
>
> On 21 January 2016 at 20:11, Bill Burke <bburke at redhat.com> wrote:
>
>>
>>
>> On 1/21/2016 1:43 PM, Stian Thorgersen wrote:
>>
>>
>>
>> On 21 January 2016 at 18:31, Bill Burke < <bburke at redhat.com>
>> bburke at redhat.com> wrote:
>>
>>> I need to create a separate adapter distro for Wildfly 10 as it is not
>>> compatible with Wildfly 8 and 9.  To do this, I need an explanation of
>>> the distribution directory for adapters
>>>
>>
>> Would it not be cleaner to incorporate something in the adapter that uses
>> different classes depending on the undertow version?
>>
>>
>> No idea what  you mean.  The undertow class/method in question has a
>> different signature between 8-9 and 10.  The method call has parameters
>> whose types don't exist in one or the other's versions.  Basically I'll be
>> creating a wildfly10-adapter-spi and wildfly9-adapter-spi jar that each
>> have one class in them.  These modules are included in the adapter-spi
>> module.  I just don't see any way around that.
>>
>> --
>> Bill Burke
>> JBoss, a division of Red Hathttp://bill.burkecentral.com
>>
>>
>
> --
> Bill Burke
> JBoss, a division of Red Hathttp://bill.burkecentral.com
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/keycloak-dev/attachments/20160121/24b54aa8/attachment.html