[keycloak-dev] Commits/PRs
Bill Burke
bburke at redhat.com
Thu Mar 10 13:03:52 EST 2016
Is there a way to automatically squash everything to your latest
commit? FYI, I just screed up the rebase so I have included like 30
commits in my PR.
On 3/10/2016 2:29 AM, Stian Thorgersen wrote:
> Please squash commits. The ideal is one commit and one PR per JIRA
> issue. If you want to break a JIRA issue into smaller tasks then
> please create sub-tasks in JIRA, then do one commit/PR for one sub-task.
>
> Always include JIRA key in the commit message. A good commit message
> look example is:
> ----
> KEYCLOAK-1267 add a separate sso_max_lifespan parameter for remember me
> ----
>
> We have automated linking of PRs in JIRA as long as the JIRA key is
> included in the commit message. It doesn't hurt to manually link as
> this is generally quicker.
>
> With JIRA key in commit and PRs linked in JIRA we get a good history
> that is useful in the future to identify what was changed and why.
> It's also important that this history goes both ways. For example if
> you don't include JIRA key in commit it's very difficult to find the
> associated JIRA issue. If you didn't even link the PR then it's pretty
> much impossible.
>
> All commits to main repository should be done through PRs, no direct
> pushing to repository please.
>
>
> _______________________________________________
> keycloak-dev mailing list
> keycloak-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/keycloak-dev
--
Bill Burke
JBoss, a division of Red Hat
http://bill.burkecentral.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/keycloak-dev/attachments/20160310/20ba3b36/attachment-0001.html
More information about the keycloak-dev
mailing list