[keycloak-dev] ProviderConfigProperty.defaultValue for LIST_TYPE

[Marek Posolda]

I've created https://issues.jboss.org/browse/KEYCLOAK-3719 . Will try to 
sort it before the release.

Marek

On 17/10/16 13:20, Marek Posolda wrote:
> +1 for "options"
>
> Marek
>
> On 17/10/16 13:03, Stian Thorgersen wrote:
>> +1 Maybe call it options? instead of availableValues.
>>
>> On 17 October 2016 at 09:48, Marek Posolda <mposolda at redhat.com
>> <mailto:mposolda at redhat.com>> wrote:
>>
>>      There is one strange thing for ProviderConfigProperties, which
>>      uses type
>>      LIST. For those, the "defaultValue" field doesn't really use
>>      defaultValue of particular field, but instead it contains list of
>>      available values to be selected in combobox for particular config
>>      property.
>>
>>      IMO this is not good because of:
>>
>>      * Field "defaultValue" is used for something, which is not really
>>      defaultValue. It's a bit confusing IMO. Note once we're adding
>>      supported
>>      UserStorage SPIs, then customers may need to add their own
>>      properties of
>>      type "List" . So this is not just Keycloak implementation detail, but
>>      it's exposed externally.
>>
>>      * It's not easily possible to set the actual defaultValue for list
>>      because field "defaultValue" is occupied by the list of available
>>      values.
>>
>>
>>      How about adding new field like "availableValues" to
>>      ProviderConfigProperty and refactor existing impls to use this one
>>      instead?
>>
>>      Marek
>>
>>      _______________________________________________
>>      keycloak-dev mailing list
>>      keycloak-dev at lists.jboss.org <mailto:keycloak-dev at lists.jboss.org>
>>      https://lists.jboss.org/mailman/listinfo/keycloak-dev
>>      <https://lists.jboss.org/mailman/listinfo/keycloak-dev>
>>
>>
> _______________________________________________
> keycloak-dev mailing list
> keycloak-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/keycloak-dev