[keycloak-dev] How to do my pull request successfully

[Bruno Oliveira]

Like Stian mentioned, it's not caused by your PR. I did a rebase and ran a
test with Travis CI, all the tests pass
https://travis-ci.org/abstractj/keycloak/builds/243201760.

The problem is related with BruteForceTest which occasionally fails.

On Wed, Jun 14, 2017 at 12:26 PM Jairo Henao <jairohenaorojas at gmail.com>
wrote:

> Thanks, but I see that it just failed again.
>
> :(
>
> On Wed, Jun 14, 2017 at 9:36 AM, Stian Thorgersen <sthorger at redhat.com>
> wrote:
>
>> Most likely you didn't break the test. We have a couple tests at the
>> moment that are unstable and fail intermittently. See
>> https://issues.jboss.org/browse/KEYCLOAK-5020.
>>
>> I've restarted the test for your PR.
>>
>> On 13 June 2017 at 17:27, Jairo Henao <jairohenaorojas at gmail.com> wrote:
>>
>>> Thanks, I have already seen the link  but can not find information:
>>>
>>> The only thing I can extract from the test log is this:
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>> *21:47:48,254 INFO  [KeycloakOnUndertow] Stopping auth server.Results
>>> :Failed tests:
>>> BruteForceTest.testGrantInvalidOtp:197->assertTokenNull:215 expected
>>> null,
>>> but
>>>
>>> was:<eyJhbGciOiJSUzI1NiIsInR5cCIgOiAiSldUIiwia2lkIiA6ICJGSjg2R2NGM2pUYk5MT2NvNE52WmtVQ0lVbWZZQ3FvcXRPUWVNZmJoTmxFIn0.eyJqdGkiOiI5M2I2NDI1MC04MjYxLTRmOTUtOTY3ZS05ZDRiOTAwYTA1M2YiLCJleHAiOjE0OTcwNDQ5MDcsIm5iZiI6MCwiaWF0IjoxNDk3MDQ0NjA3LCJpc3MiOiJodHRwOi8vbG9jYWxob3N0OjgxODAvYXV0aC9yZWFsbXMvdGVzdCIsImF1ZCI6InRlc3QtYXBwIiwic3ViIjoiYTM2Nzk1MmQtMTQ5ZS00NTRjLWFmZWMtZDU2MjNkZWFhYzZlIiwidHlwIjoiQmVhcmVyIiwiYXpwIjoidGVzdC1hcHAiLCJhdXRoX3RpbWUiOjAsInNlc3Npb25fc3RhdGUiOiI3YzI5M2ZhMC1iYzkxLTRjNjQtYWM1MS1lZWEyYTY1M2I2MjAiLCJhY3IiOiIxIiwiYWxsb3dlZC1vcmlnaW5zIjpbImh0dHA6Ly9sb2NhbGhvc3Q6ODE4MCJdLCJyZWFsbV9hY2Nlc3MiOnsicm9sZXMiOlsidXNlciJdfSwicmVzb3VyY2VfYWNjZXNzIjp7InRlc3QtYXBwIjp7InJvbGVzIjpbImN1c3RvbWVyLXVzZXIiXX0sImFjY291bnQiOnsicm9sZXMiOlsibWFuYWdlLWFjY291bnQiLCJtYW5hZ2UtYWNjb3VudC1saW5rcyIsInZpZXctcHJvZmlsZSJdfX0sIm5hbWUiOiJUb20gQnJhZHkiLCJwcmVmZXJyZWRfdXNlcm5hbWUiOiJ0ZXN0LXVzZXJAbG9jYWxob3N0IiwiZ2l2ZW5fbmFtZSI6IlRvbSIsImZhbWlseV9uYW1lIjoiQnJhZHkiLCJlbWFpbCI6InRlc3QtdXNlckBsb2NhbGhvc3Qi!
>>>
>>>  fQ.cGA5MmxrvKW_O7B100jotT4f4jb9ctOBizuGyINor579NRWUAutllM9OGEniPtDedZ1_m_IGmbXteiixhg--SG0dDHTec8CYxQZrtC2TjDBzdxkWYj3iHL0Yj-1wcZZEaGb3809ol94oVrjOXcbcpjU-wAmQtK4RhRyoy-a3O-E>
>>> BruteForceTest.testGrantMissingOtp:246->assertTokenNull:215 expected
>>> null,
>>> but
>>>
>>> was:<eyJhbGciOiJSUzI1NiIsInR5cCIgOiAiSldUIiwia2lkIiA6ICJGSjg2R2NGM2pUYk5MT2NvNE52WmtVQ0lVbWZZQ3FvcXRPUWVNZmJoTmxFIn0.eyJqdGkiOiJiNGE1NjY3YS04ZjhlLTQ1YjctYTYzMy01ZDdhNzczMzlkNmEiLCJleHAiOjE0OTcwNDQ5MjIsIm5iZiI6MCwiaWF0IjoxNDk3MDQ0NjIyLCJpc3MiOiJodHRwOi8vbG9jYWxob3N0OjgxODAvYXV0aC9yZWFsbXMvdGVzdCIsImF1ZCI6InRlc3QtYXBwIiwic3ViIjoiYTM2Nzk1MmQtMTQ5ZS00NTRjLWFmZWMtZDU2MjNkZWFhYzZlIiwidHlwIjoiQmVhcmVyIiwiYXpwIjoidGVzdC1hcHAiLCJhdXRoX3RpbWUiOjAsInNlc3Npb25fc3RhdGUiOiJlZDg2YWI5Ni1mMDk1LTQwNTItODExYS0wNzNjNjY5ZjBiYjIiLCJhY3IiOiIxIiwiYWxsb3dlZC1vcmlnaW5zIjpbImh0dHA6Ly9sb2NhbGhvc3Q6ODE4MCJdLCJyZWFsbV9hY2Nlc3MiOnsicm9sZXMiOlsidXNlciJdfSwicmVzb3VyY2VfYWNjZXNzIjp7InRlc3QtYXBwIjp7InJvbGVzIjpbImN1c3RvbWVyLXVzZXIiXX0sImFjY291bnQiOnsicm9sZXMiOlsibWFuYWdlLWFjY291bnQiLCJtYW5hZ2UtYWNjb3VudC1saW5rcyIsInZpZXctcHJvZmlsZSJdfX0sIm5hbWUiOiJUb20gQnJhZHkiLCJwcmVmZXJyZWRfdXNlcm5hbWUiOiJ0ZXN0LXVzZXJAbG9jYWxob3N0IiwiZ2l2ZW5fbmFtZSI6IlRvbSIsImZhbWlseV9uYW1lIjoiQnJhZHkiLCJlbWFpbCI6InRlc3QtdXNlckBsb2NhbGhvc3Qi!
>>>
>>>  fQ.iXHI9NkRM8CaVX_iqIlAXcQGBhg-TH27F58C4XEDgCc_QawXKJ1GZ0qauVTnoS2mJB8ecW74V9HFpo-O0GVt4DyQzEw8dk0UUZtpsKrwLYk-IO0N6sitxJLr_wTjUTtcYJttOSnecuPB5XsxeSK6Lio4eNVarGRO00hNg7h3w1Y>Tests
>>> run: 191, Failures: 2, Errors: 0, Skipped: 2*
>>>
>>>
>>>
>>> On Tue, Jun 13, 2017 at 9:13 AM, Bruno Oliveira <bruno at abstractj.org>
>>> wrote:
>>>
>>> > https://github.com/keycloak/keycloak#contributing
>>> >
>>> > On Tue, Jun 13, 2017 at 10:58 AM Jairo Henao <
>>> jairohenaorojas at gmail.com>
>>> > wrote:
>>> >
>>> >> Hello comunity,
>>> >>
>>> >> I am trying to understand the process to contribute to the project. A
>>> few
>>> >> days ago I did my first pull request but some errors occurred while
>>> >> running
>>> >> the tests. I do not understand the error very well, what is the
>>> process
>>> >> here ?, Where can I find more information ?, This is the channel
>>> where I
>>> >> should ask about this?
>>> >>
>>> >> https://github.com/keycloak/keycloak/pull/4219
>>> >>
>>> >>
>>> >> Thanks
>>> >> _______________________________________________
>>> >> keycloak-dev mailing list
>>> >> keycloak-dev at lists.jboss.org
>>> >> https://lists.jboss.org/mailman/listinfo/keycloak-dev
>>> >>
>>> >
>>>
>>>
>>> --
>>> _______________________________________________
>>> keycloak-dev mailing list
>>> keycloak-dev at lists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/keycloak-dev
>>>
>>
>>
>
>
> --
>