[keycloak-dev] master build failing on Tomcat 6

[Stian Thorgersen]

Awesome Marko,

Thanks for sorting this out. I've added a new PR here
https://github.com/keycloak/keycloak/pull/4478 with your fix and also
adding tomcat6 to what Travis tests so this doesn't happen again.

On 14 September 2017 at 10:17, Marko Strukelj <mstrukel at redhat.com> wrote:

> I got this as well.
>
> The problem is with org.wildfly:wildfly-undertow test dependency which
> pulls in io.undertow.jastow:jastow that contains Tomcat util classes.
>
> Hopefully we don't make use of any undertow facility dependent on jastow
> thus the fix would be to simply exclude the dependency.
>
> Testing the following as a fix:
>
> Index: pom.xml
> IDEA additional info:
> Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
> <+>UTF-8
> ===================================================================
> --- pom.xml (date 1505336045000)
> +++ pom.xml (revision )
> @@ -591,6 +591,12 @@
>                  <artifactId>wildfly-undertow</artifactId>
>                  <version>${wildfly.version}</version>
>                  <scope>test</scope>
> +                <exclusions>
> +                    <exclusion>
> +                        <groupId>io.undertow.jastow</groupId>
> +                        <artifactId>jastow</artifactId>
> +                    </exclusion>
> +                </exclusions>
>              </dependency>
>              <dependency>
>                  <groupId>org.wildfly.core</groupId>
>
>
> On Tue, Sep 12, 2017 at 9:54 PM, Stian Thorgersen <sthorger at redhat.com>
> wrote:
>
>> I'm seeing this as well. Anyone sign up to getting this fixed?
>>
>> On 7 September 2017 at 17:34, Bill Burke <bburke at redhat.com> wrote:
>>
>> > Tomcat 6 test is failing on my box.  I pulled fresh copy of master and
>> > removed org/keycloak from .m2.  So I don't think its anything local on
>> > my machine:
>> >
>> > java.lang.NoSuchMethodError:
>> > org.apache.tomcat.util.descriptor.DigesterFactory.
>> > newDigester(ZZLorg/apache/tomcat/util/digester/RuleSet;
>> > Z)Lorg/apache/tomcat/util/digester/Digester;
>> >
>> > at org.apache.catalina.startup.ContextConfig.createWebXmlDigester(
>> > ContextConfig.java:527)
>> >
>> > at org.apache.catalina.startup.ContextConfig.init(ContextConfig
>> .java:1015)
>> >
>> > at org.apache.catalina.startup.ContextConfig.lifecycleEvent(
>> > ContextConfig.java:276)
>> >
>> > at org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(
>> > LifecycleSupport.java:142)
>> >
>> > at org.apache.catalina.core.StandardContext.init(
>> > StandardContext.java:5703)
>> >
>> > at org.apache.catalina.core.StandardContext.start(
>> > StandardContext.java:4453)
>> >
>> > at org.apache.catalina.core.ContainerBase.start(ContainerBase.
>> java:1057)
>> >
>> > at org.apache.catalina.core.StandardHost.start(StandardHost.java:822)
>> >
>> > at org.apache.catalina.core.ContainerBase.start(ContainerBase.
>> java:1057)
>> >
>> > at org.apache.catalina.core.StandardEngine.start(StandardEngine
>> .java:463)
>> >
>> > at org.apache.catalina.startup.Embedded.start(Embedded.java:825)
>> >
>> > at org.keycloak.testsuite.TomcatServer.start(TomcatServer.java:122)
>> >
>> > at org.keycloak.testsuite.TomcatTest.initTomcat(TomcatTest.java:66)
>> >
>> >
>> >
>> >
>> > --
>> > Bill Burke
>> > Red Hat
>> > _______________________________________________
>> > keycloak-dev mailing list
>> > keycloak-dev at lists.jboss.org
>> > https://lists.jboss.org/mailman/listinfo/keycloak-dev
>> >
>> _______________________________________________
>> keycloak-dev mailing list
>> keycloak-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/keycloak-dev
>>
>
>