[keycloak-dev] Proposal: Update Dockerfiles to use jboss-cli

Iván Perdomo ivan at akvo.org
Fri Sep 15 04:49:24 EDT 2017


Hi,

There are not that many environment variables, basically Keycloak and
Maven version, plus LAUNCH_JBOSS_IN_BACKGROUND for 'graceful shutdown'.
The only i one i see that actually modifies behavior is the
PROXY_ADDRESS_FORWARDING when the service is behind a reverse proxy.

$ grep -rn ENV .
./server/Dockerfile:3:ENV KEYCLOAK_VERSION 3.3.0.CR2
./server/Dockerfile:6:ENV LAUNCH_JBOSS_IN_BACKGROUND 1
./server/Dockerfile:7:ENV PROXY_ADDRESS_FORWARDING false
./server/Dockerfile:21:ENV JBOSS_HOME /opt/jboss/keycloak
./server-postgres/Dockerfile:3:ENV POSTGRES_JDBC_VERSION 42.1.4
./proxy/Dockerfile:3:ENV KEYCLOAK_VERSION 3.2.0.Final
./examples/Dockerfile:3:ENV KEYCLOAK_VERSION 3.3.0.CR2
./examples/Dockerfile:4:ENV JBOSS_HOME /opt/jboss/keycloak-demo/keycloak
./examples/Dockerfile:5:ENV MAVEN_VERSION 3.3.9
./examples/Dockerfile:8:ENV LAUNCH_JBOSS_IN_BACKGROUND 1
./examples/Dockerfile:16:ENV MAVEN_HOME /usr/share/maven
./adapter-wildfly/Dockerfile:3:ENV KEYCLOAK_VERSION 3.3.0.CR2

Cheers,


On 09/14/2017 05:03 PM, Bill Burke wrote:
> Just a thought, just brainstorming...
> 
> Maybe all environment variables should be ditched and only jboss-cli
> should be supported?  Users extend the Keycloak image, hardcode the
> things they want to hardcode via jboss-cli, introduce their own
> environment variables as parameters to CLI as they see fit.  Just
> seems like a much better option than having to duplicate and document
> pre-defined environment variables.
> 
> On Thu, Sep 14, 2017 at 12:51 AM, Stian Thorgersen <sthorger at redhat.com> wrote:
>> Absolutely :)
>>
>> On 13 September 2017 at 12:53, Iván Perdomo <ivan at akvo.org> wrote:
>>
>>>
>>> Hi all,
>>>
>>> Thanks to Rubén [1] we have successfully changed our customization to
>>> Keycloak Docker images using jboss-cli and embed-server, instead of XSLT
>>> transformations.
>>>
>>> In the past Stian has suggested that the XSLT was done before
>>> embed-server was available [2].
>>>
>>> We would like to contribute some of this changes to the base images. Can
>>> we log an issue and send a pull request?
>>>
>>> The proposed changes will be just to remove xlst transformations with
>>> jboss-cli commands.
>>>
>>>
>>> [1] https://github.com/baztan106483
>>> [2]
>>> https://lists.jboss.org/pipermail/keycloak-user/2016-February/005120.html
>>>
>>> Thanks,
>>>
>>> --
>>> Iván
>>> _______________________________________________
>>> keycloak-dev mailing list
>>> keycloak-dev at lists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/keycloak-dev
>> _______________________________________________
>> keycloak-dev mailing list
>> keycloak-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/keycloak-dev
> 
> 
> 

-- 
Iván


More information about the keycloak-dev mailing list