[keycloak-dev] [keycloak-user] Switching to Native JavaScript promise by default
Stian Thorgersen
sthorger at redhat.com
Tue Feb 5 01:20:39 EST 2019
The switch will most likely be done in Keycloak 6, which is a while from
now. So we should fix any issues in the meantime. Can you report a bug for
this issue please?
On Mon, 28 Jan 2019 at 07:18, Dmitry Telegin <dt at acutus.pro> wrote:
> Hi, are there any particular plans for it?
>
> I think I've found a promise-related bug in JS adapter, but not sure if it
> makes any sense fixing it, since the whole thing is going to be
> transitioned to native promises.
>
> The bug is that the success()/error() functions are expected in doLogin()
> (keycloak.js:145), but the corresponding createPromise() is called without
> explicit true arg (line 1163), so if { promiseType: 'native' } is used,
> doLogin() will barf with "TypeError: kc.login(...).success is not a
> function".
>
> Cheers,
> Dmitry
>
> On Thu, 2019-01-17 at 08:55 +0100, Stian Thorgersen wrote:
> > I would like to switch the JavaScript adapter to use Native promises by
> > default and deprecate the legacy promise with the aim to remove it in the
> > future.
> >
> > This would result in users that want to continue to use the legacy
> promise
> > having to explicitly enable this in the config.
> >
> > I see this as the best path to eventually remove the legacy promises.
> > _______________________________________________
> > keycloak-user mailing list
> > keycloak-user at lists.jboss.org
> > https://lists.jboss.org/mailman/listinfo/keycloak-user
>
More information about the keycloak-dev
mailing list