[keycloak-dev] [keycloak-user] Switching to Native JavaScript promise by default

[Dmitry Telegin]

Hi, are there any particular plans for it?

I think I've found a promise-related bug in JS adapter, but not sure if it makes any sense fixing it, since the whole thing is going to be transitioned to native promises.

The bug is that the success()/error() functions are expected in doLogin() (keycloak.js:145), but the corresponding createPromise() is called without explicit true arg (line 1163), so if { promiseType: 'native' } is used, doLogin() will barf with "TypeError: kc.login(...).success is not a function".

Cheers,
Dmitry

On Thu, 2019-01-17 at 08:55 +0100, Stian Thorgersen wrote:
> I would like to switch the JavaScript adapter to use Native promises by
> default and deprecate the legacy promise with the aim to remove it in the
> future.
> 
> This would result in users that want to continue to use the legacy promise
> having to explicitly enable this in the config.
> 
> I see this as the best path to eventually remove the legacy promises.
> _______________________________________________
> keycloak-user mailing list
> keycloak-user at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/keycloak-user