[keycloak-dev] Master update breaks account console

[Stan Silvert]

Looks like I'm only using it for:

${authUrl}/js/keycloak.js
${authUrl}/realms/${realm.name}/account/keycloak.json So it's no problem 
to change on my end. I was just worried that someone in the community 
might be using the same API and expecting a return value without the slash.

On 11/14/2019 6:56 AM, Stian Thorgersen wrote:
> Yes, this was changed due to default hostname provider.
>
> Stan do you need the auth-url or a URL to something else? If the 
> latter the safest is to use the builder to get the path, unless you 
> are doing that on the client side.
>
> On Thu, 14 Nov 2019 at 10:07, Jan Lieskovsky <jlieskov at redhat.com 
> <mailto:jlieskov at redhat.com>> wrote:
>
>
>     On Wed, Nov 13, 2019 at 10:46 PM Stan Silvert <ssilvert at redhat.com
>     <mailto:ssilvert at redhat.com>> wrote:
>
>         In new account console, I pass the auth URL to Freemarker.  I
>         call:
>
>         session.getContext().getUri(UrlType.FRONTEND).getBaseUri().toString())
>
>         This has always returned something like
>         "http://localhost:8080/auth"
>
>         However, the latest in master puts a slash at the end,
>         "http://localhost:8080/auth/"
>
>
>         I can easily update my code for this to work, but I'm
>         concerned that
>         this change might have broken more than just the new account
>         console.
>         Perhaps other code in the community is relying on the URL not
>         having a
>         slash at the end.
>
>         Does anyone recognize the change that might have caused this?
>
>
>     Might be related with the recent new default hostname provider
>     (KEYCLOAK-11728) change.
>     At least this change in corresponding test acceptance criteria
>     <https://github.com/keycloak/keycloak/commit/b8881b8ea062afa2f1b5a613dd856900b73f2121#diff-42f10e03d16b143ad9c65c3791f8c387L92>
>     would suggest so.
>
>     But given the corresponding test was changed to expect slash at
>     the end, I would say this
>     is expected behaviour now. @Stian Thorgersen
>     <mailto:stian at redhat.com> Can you confirm?
>
>
>         Stan
>
>
>     Thank you && Regards, Jan
>     --
>     Jan iankko Lieskovsky / Keycloak / RH-SSO Team
>
>
>         _______________________________________________
>         keycloak-dev mailing list
>         keycloak-dev at lists.jboss.org <mailto:keycloak-dev at lists.jboss.org>
>         https://lists.jboss.org/mailman/listinfo/keycloak-dev
>