[keycloak-dev] Feedback on PRs

[乗松隆志 / NORIMATSU，TAKASHI]

Hello Bruno,

Thank you for your comment.

To review the PR, can I follow the following procedure by myself without any instruction by some keycloak's maintainer? :

* Pick up PRs to which no Reviewers is assigned (and excludes my issuing PRs)
* Among those PRs, pick up the one that I can review
* Review it and put some comments on it

And after that, can I provide "approved" to the PR by myself? (I'm not sure what "approved" means in the PR of keycloak repository)

Regards,

Takashi Norimatsu
Hitachi, Ltd.

-----Original Message-----
From: Bruno Oliveira <bruno at abstractj.org> 
Sent: Wednesday, September 18, 2019 7:37 PM
To: 乗松隆志 / NORIMATSU，TAKASHI <takashi.norimatsu.ws at hitachi.com>
Cc: keycloak-dev at lists.jboss.org
Subject: [!]Re: [keycloak-dev] Feedback on PRs

Hi Takashi, I guess any community member can comment on PRs or provide their approval. If not, please let us know. You're more than welcome to review PRs.

On Tue, Sep 17, 2019 at 10:33 PM 乗松隆志 / NORIMATSU，TAKASHI
<takashi.norimatsu.ws at hitachi.com> wrote:
>
> Hello,
>
> I've contributed some features onto keycloak.
> Besides that, I am also interested in participating in reviewing PRs.
>
> Regards,
>
> Takashi Norimatsu
> Hitachi, Ltd.
>
> -----Original Message-----
> From: keycloak-dev-bounces at lists.jboss.org 
> <keycloak-dev-bounces at lists.jboss.org> On Behalf Of Stian Thorgersen
> Sent: Tuesday, September 10, 2019 5:26 PM
> To: keycloak-dev <keycloak-dev at lists.jboss.org>
> Subject: [!][keycloak-dev] Feedback on PRs
>
> First of all thanks to everyone that has sent a PR to Keycloak. Without the communities participation Keycloak wouldn't be the same!
>
> At the moment we are struggling a bit with keeping up with reviewing PRs so please bear with us. We are discussing in the team how we can improve on the current situation. Suggestions are obviously welcome.
>
> We would also love it if people from the community would also participate in reviewing PRs. We highly value your input.
> _______________________________________________
> keycloak-dev mailing list
> keycloak-dev at lists.jboss.org
> https://clicktime.symantec.com/3HaaoZr4VxVY3aPuJU4sGJJ7Vc?u=https%3A%2
> F%2Flists.jboss.org%2Fmailman%2Flistinfo%2Fkeycloak-dev
>
> _______________________________________________
> keycloak-dev mailing list
> keycloak-dev at lists.jboss.org
> https://clicktime.symantec.com/3HaaoZr4VxVY3aPuJU4sGJJ7Vc?u=https%3A%2
> F%2Flists.jboss.org%2Fmailman%2Flistinfo%2Fkeycloak-dev



--
- abstractj