[keycloak-dev] Feedback on PRs

[Stian Thorgersen]

Sure, I was just wondering if you have access to use GitHubs review
feature. I.e. on the page
https://github.com/keycloak/keycloak/pull/6267/files do you see a green
button "Review changes"?

On Fri, 20 Sep 2019 at 11:06, 乗松隆志 / NORIMATSU，TAKASHI <
takashi.norimatsu.ws at hitachi.com> wrote:

> Sorry for confusing, in the previous mail, "Reviewer" does not stands for
> github's "Reviewer" role. I would like to simply review and add comments on
> the open PR.
>
>
>
> *From:* Stian Thorgersen <sthorger at redhat.com>
> *Sent:* Friday, September 20, 2019 6:00 PM
> *To:* 乗松隆志 / NORIMATSU，TAKASHI <takashi.norimatsu.ws at hitachi.com>
> *Cc:* Bruno Oliveira <bruno at abstractj.org>; keycloak-dev at lists.jboss.org;
> 中村雄一 / NAKAMURA，YUUICHI <yuichi.nakamura.fe at hitachi.com>
> *Subject:* [!]Re: Re: [keycloak-dev] Feedback on PRs
>
>
>
> Do you have ability to add reviews for PRs? Not sure if GitHub requires
> you to be a part of the organization or something to be able to do that.
>
>
>
> On Fri, 20 Sep 2019 at 10:58, 乗松隆志 / NORIMATSU，TAKASHI <
> takashi.norimatsu.ws at hitachi.com> wrote:
>
> Hello Stian,
>
>
>
> Thank you for your suggestion.
>
>
>
> As you said, I would like to try to review some open PR as Reviewer
> actually.
>
>
>
> Regards,
>
>
>
> Takashi Norimatsu
>
> Hitachi, Ltd.
>
>
>
>
>
> *From:* Stian Thorgersen <sthorger at redhat.com>
> *Sent:* Friday, September 20, 2019 5:49 PM
> *To:* 乗松隆志 / NORIMATSU，TAKASHI <takashi.norimatsu.ws at hitachi.com>
> *Cc:* Bruno Oliveira <bruno at abstractj.org>; keycloak-dev at lists.jboss.org
> *Subject:* [!]Re: [keycloak-dev] Feedback on PRs
>
>
>
>
>
> On Fri, 20 Sep 2019 at 02:52, 乗松隆志 / NORIMATSU，TAKASHI <
> takashi.norimatsu.ws at hitachi.com> wrote:
>
> Hello Bruno,
>
> Thank you for your comment.
>
> To review the PR, can I follow the following procedure by myself without
> any instruction by some keycloak's maintainer? :
>
>
> * Pick up PRs to which no Reviewers is assigned (and excludes my issuing
> PRs)
>
>
>
> Feel free to review and open PRs. Feedback and review from the community
> is welcome on everything.
>
>
>
> * Among those PRs, pick up the one that I can review
> * Review it and put some comments on it
>
> And after that, can I provide "approved" to the PR by myself? (I'm not
> sure what "approved" means in the PR of keycloak repository)
>
>
>
> The assignee of a PR is responsible to determine if the PR has been
> sufficiently reviewed and can be merged. The assignee will use feedback
> from reviewers as a basis for this decision.
>
>
>
>
> Regards,
>
> Takashi Norimatsu
> Hitachi, Ltd.
>
> -----Original Message-----
> From: Bruno Oliveira <bruno at abstractj.org>
> Sent: Wednesday, September 18, 2019 7:37 PM
> To: 乗松隆志 / NORIMATSU，TAKASHI <takashi.norimatsu.ws at hitachi.com>
> Cc: keycloak-dev at lists.jboss.org
> Subject: [!]Re: [keycloak-dev] Feedback on PRs
>
> Hi Takashi, I guess any community member can comment on PRs or provide
> their approval. If not, please let us know. You're more than welcome to
> review PRs.
>
> On Tue, Sep 17, 2019 at 10:33 PM 乗松隆志 / NORIMATSU，TAKASHI
> <takashi.norimatsu.ws at hitachi.com> wrote:
> >
> > Hello,
> >
> > I've contributed some features onto keycloak.
> > Besides that, I am also interested in participating in reviewing PRs.
> >
> > Regards,
> >
> > Takashi Norimatsu
> > Hitachi, Ltd.
> >
> > -----Original Message-----
> > From: keycloak-dev-bounces at lists.jboss.org
> > <keycloak-dev-bounces at lists.jboss.org> On Behalf Of Stian Thorgersen
> > Sent: Tuesday, September 10, 2019 5:26 PM
> > To: keycloak-dev <keycloak-dev at lists.jboss.org>
> > Subject: [!][keycloak-dev] Feedback on PRs
> >
> > First of all thanks to everyone that has sent a PR to Keycloak. Without
> the communities participation Keycloak wouldn't be the same!
> >
> > At the moment we are struggling a bit with keeping up with reviewing PRs
> so please bear with us. We are discussing in the team how we can improve on
> the current situation. Suggestions are obviously welcome.
> >
> > We would also love it if people from the community would also
> participate in reviewing PRs. We highly value your input.
> > _______________________________________________
> > keycloak-dev mailing list
> > keycloak-dev at lists.jboss.org
> > https://clicktime.symantec.com/3HaaoZr4VxVY3aPuJU4sGJJ7Vc?u=https%3A%2
> <https://clicktime.symantec.com/3HaaoZr4VxVY3aPuJU4sGJJ7Vc?u=https%3A%252>
> > F%2Flists.jboss.org
> <https://clicktime.symantec.com/33vnH3F8mHFNHzKyYDVCUWb7Vc?u=http%3A%2F%2F2Flists.jboss.org>
> %2Fmailman%2Flistinfo%2Fkeycloak-dev
> >
> > _______________________________________________
> > keycloak-dev mailing list
> > keycloak-dev at lists.jboss.org
> > https://clicktime.symantec.com/3HaaoZr4VxVY3aPuJU4sGJJ7Vc?u=https%3A%2
> <https://clicktime.symantec.com/3HaaoZr4VxVY3aPuJU4sGJJ7Vc?u=https%3A%252>
> > F%2Flists.jboss.org
> <https://clicktime.symantec.com/33vnH3F8mHFNHzKyYDVCUWb7Vc?u=http%3A%2F%2F2Flists.jboss.org>
> %2Fmailman%2Flistinfo%2Fkeycloak-dev
>
>
>
> --
> - abstractj
>
> _______________________________________________
> keycloak-dev mailing list
> keycloak-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/keycloak-dev
> <https://clicktime.symantec.com/3KYxPNoxDNdVjzRx2EDt75j7Vc?u=https%3A%2F%2Flists.jboss.org%2Fmailman%2Flistinfo%2Fkeycloak-dev>
>
>