[mod_cluster-issues] [JBoss JIRA] (MODCLUSTER-285) get_path_param in mod_proxy_cluster doesn't expect '; ' as separator

[Stefano Nichele (JIRA)]

Stefano Nichele created MODCLUSTER-285:
------------------------------------------

             Summary: get_path_param in mod_proxy_cluster doesn't expect ';' as separator
                 Key: MODCLUSTER-285
                 URL: https://issues.jboss.org/browse/MODCLUSTER-285
             Project: mod_cluster
          Issue Type: Bug
    Affects Versions: 1.2.0.Final, 1.1.3.Final
            Reporter: Stefano Nichele
            Assignee: Jean-Frederic Clere


Current version of get_path_param doesn't expect ';' as path parameters separator so this urls are not correctly handled:

/test.jsp;jsessionid=123123.NODE01;name=vale

See for instance the mod_proxy_balancer implementation (in httpd 2.2.21):

/* Retrieve the parameter with the given name
 * Something like 'JSESSIONID=12345...N'
 */
static char *get_path_param(apr_pool_t *pool, char *url,
                            const char *name, int scolon_sep)
{
    char *path = NULL;
    char *pathdelims = "?&";

    if (scolon_sep) {
        pathdelims = ";?&";
    }
    for (path = strstr(url, name); path; path = strstr(path + 1, name)) {
        path += strlen(name);
        if (*path == '=') {
            /*
             * Session path was found, get it's value
             */
            ++path;
            if (strlen(path)) {
                char *q;
                path = apr_strtok(apr_pstrdup(pool, path), pathdelims, &q);
                return path;
            }
        }
    }
    return NULL;
}

Severity of this bug to me is not so high since using more than one path parameters is not so common.


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira