[mod_cluster-issues] [JBoss JIRA] (MODCLUSTER-528) Re-think catalina/tomcat dependencies so as it is possible to build without tomcat7 API

[Radoslav Husar (JIRA)]

    [ https://issues.jboss.org/browse/MODCLUSTER-528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273030#comment-13273030 ] 

Radoslav Husar commented on MODCLUSTER-528:
-------------------------------------------

Unfortunately there is not much more that could be done here apart from patching. To build the base (called tomcat module based on tomcat7 in master) withouth tomcat7 dependencies, the patch would "unimplement" the methods (throw MethodNotImplementedException) and remove the imports and in runtime, these methods are overriden.

To build master with tomcat8 dependencies just apply this patch and use -PTC8. 
{noformat}
diff --git a/container/tomcat/pom.xml b/container/tomcat/pom.xml
index 0fcc914..1abce26 100644
--- a/container/tomcat/pom.xml
+++ b/container/tomcat/pom.xml
@@ -48,7 +48,6 @@
         </dependency>
     </dependencies>
     <profiles>
-        <!--
         <profile>
             <id>TC9</id>
             <activation>
@@ -145,7 +144,6 @@
                 </dependency>
             </dependencies>
         </profile>
-        -->
         <profile>
             <id>TC7</id>
             <activation>
{noformat}

> Re-think catalina/tomcat dependencies so as it is possible to build without tomcat7 API
> ---------------------------------------------------------------------------------------
>
>                 Key: MODCLUSTER-528
>                 URL: https://issues.jboss.org/browse/MODCLUSTER-528
>             Project: mod_cluster
>          Issue Type: Enhancement
>    Affects Versions: 1.3.3.Final
>            Reporter: Michal Karm Babacek
>            Assignee: Radoslav Husar
>             Fix For: 2.0.0.Alpha1
>
>
> It is not possible (or I'm doing something wrong)  to build mod_cluster Tomcat libs with Tomcat 8-only  API.
> I hit this problem with RPM build on Fedora where I cannot download random stuff from maven central and I need to specify dependencies beforehand.
> h3. Description
>  * container/catalina contains calls to API that is deprecated in Tomcat 7 and missing in Tomcat 8, so I have to apply this patch: [MODCLUSTER-528-CatalinaContext.java.patch|https://github.com/Karm/mod_cluster-fedora-packages/blob/master/MODCLUSTER-528-CatalinaContext.java.patch] before build
>  * profiles and test dependencies and Servlet API dependencies needs hacks to build without Tomcat 7 too:  see other patches in [mod_cluster-fedora-packages/|https://github.com/Karm/mod_cluster-fedora-packages/]
> h3. Suggestion
>  * architecture dependencies so as it is possible to build mod_cluster with Tomcat 8 API only (and Tomcat 7 API only)
>  * drop Tomcat 6 and JBossWeb from 1.3.x as they are not used in 1.3.x anyway (last use of Tomcat 6 and JBossWeb is 1.2.x)
> h3. Fedora 24 offers only Tomcat 8
> ...so does it even make sense to offer users Tomcat 7 libs RPM? At the moment, I have it disabled. Note: Former mod_cluster RPM (1.2.6) hasn't been distributing any usable tomcat integration; it has been AS7/JBossWeb one.



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)