[mod_cluster-issues] [JBoss JIRA] (MODCLUSTER-621) maxbufsize doesn't include JVMROUTESZ
Jean-Frederic Clere (Jira)
issues at jboss.org
Sat Apr 6 04:38:01 EDT 2019
[ https://issues.jboss.org/browse/MODCLUSTER-621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Frederic Clere resolved MODCLUSTER-621.
--------------------------------------------
Fix Version/s: 2.0.0.Alpha2
Resolution: Done
fixed by https://github.com/modcluster/mod_proxy_cluster/commit/1414bd8ae519650dc231b265cdba617ba88600d3
> maxbufsize doesn't include JVMROUTESZ
> -------------------------------------
>
> Key: MODCLUSTER-621
> URL: https://issues.jboss.org/browse/MODCLUSTER-621
> Project: mod_cluster
> Issue Type: Bug
> Components: Native (httpd modules)
> Reporter: Robert Bost
> Assignee: Jean-Frederic Clere
> Priority: Major
> Fix For: 2.0.0.Alpha2
>
>
> https://github.com/modcluster/mod_proxy_cluster/blob/master/native/mod_manager/mod_manager.c#L2956-L2959
> {code}
> if (mconf->maxmesssize)
> maxbufsiz = mconf->maxmesssize;
> else {
> /* we calculate it */
> maxbufsiz = 9 + JVMROUTESZ;
> maxbufsiz = bufsiz + (mconf->maxhost * HOSTALIASZ) + 7;
> maxbufsiz = bufsiz + (mconf->maxcontext * CONTEXTSZ) + 8;
> }
> if (maxbufsiz< MAXMESSSIZE)
> maxbufsiz = MAXMESSSIZE;
> buff = apr_pcalloc(r->pool, maxbufsiz);
> {code}
> It looks like {{maxbufsize}} will never include the {{9+JVMROUTESZ}} since it overwritten with new value in following line. Is this a problem?
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
More information about the mod_cluster-issues
mailing list