[mod_cluster-issues] [JBoss JIRA] (MODCLUSTER-508) &balancer->name[11], because of default: balancer://mycluster: Change magic number 11 to something meaningful

[Jean-Frederic Clere (Jira)]

    [ https://issues.jboss.org/browse/MODCLUSTER-508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13719038#comment-13719038 ] 

Jean-Frederic Clere commented on MODCLUSTER-508:
------------------------------------------------

#define BALANCER_PREFIX "balancer://" im mod_proxy
https://github.com/apache/httpd/blob/2.4.x/modules/proxy/mod_proxy.h#L94

> &balancer->name[11], because of default: balancer://mycluster: Change magic number 11 to something meaningful
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: MODCLUSTER-508
>                 URL: https://issues.jboss.org/browse/MODCLUSTER-508
>             Project: mod_cluster
>          Issue Type: Enhancement
>          Components: Native (httpd modules)
>    Affects Versions: 1.3.2.Final, 1.2.13.Final
>            Reporter: Michal Karm
>            Assignee: Michal Karm
>            Priority: Trivial
>
> While we compare balancers URL char by char, we start at index 11, because
> the default beginning: {{balancer://}} is always there. It would be nice to change 11 to a named constant so as it is clear why it's 11 without debugger :)



--
This message was sent by Atlassian Jira
(v7.12.1#712002)