[JBoss JIRA] Created: (NETTY-255) Make CookieDecoder more robust

Trustin Lee (JIRA) jira-events at lists.jboss.org
Thu Nov 19 04:45:30 EST 2009


Make CookieDecoder more robust
------------------------------

                 Key: NETTY-255
                 URL: https://jira.jboss.org/jira/browse/NETTY-255
             Project: Netty
          Issue Type: Feature Request
          Components: Handler
            Reporter: Trustin Lee
            Assignee: Trustin Lee
             Fix For: 3.2.0.ALPHA2


The following Google Analytics cookie violates the RFC, but it should be decoded without an error:

        String source =
            "ARPT=LWUKQPSWRTUN04CKKJI; " +
            "kw-2E343B92-B097-442c-BFA5-BE371E0325A2=unfinished furniture; " +
            "__utma=48461872.1094088325.1258140131.1258140131.1258140131.1; " +
            "__utmb=48461872.13.10.1258140131; __utmc=48461872; " +
            "__utmz=48461872.1258140131.1.1.utmcsr=overstock.com|utmccn=(referral)|" +
            "utmcmd=referral|utmcct=/Home-Garden/Furniture/Clearance,/clearance,/32/dept.html";

What's causing the problem is the comma (,) in the "__utmz" attribute.  According to the relevant RFCs, the cookie value should not contain a comma or should be quoted.  CookieDecoder considers comma as an attribute separator unless it appears as a part of a quoted string.  Hence "/clearance,/32/dept.html" becomes an orphan.

CookieDecoder could become more robust if it does not recognize commas and semicolons as attribute separators if it's impossible to decode the next entry.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        


More information about the netty-dev mailing list