New ChannelBuffer type proposed

Frederic Bregier fredbregier at free.fr
Wed Sep 2 03:06:42 EDT 2009


Hi Trustin,

Ok I write and test the slice functionality (using Junit).
It seems OK.

I still feel like writeBytes should be left as the default implementation
(ie the one from AbstractChannelBuffer) since the setBytes method should do
the trick as usual.
I test by using the default implementation, and all tests pass too...
So, except if you think that writing by slice from source could be useful
(if the source is an aggregate one), I think this method could be removed
from Aggregate (so not implementing in the modified version of Component if
ok) so letting the default one be called.
I put a comment on this method.

Cheers,
Frederic

http://n2.nabble.com/file/n3565134/AggregateChannelBuffer.java
AggregateChannelBuffer.java 
http://n2.nabble.com/file/n3565134/AggregateChannelBufferTest.java
AggregateChannelBufferTest.java 


-----
Hardware/Software Architect
-- 
View this message in context: http://n2.nabble.com/New-ChannelBuffer-type-proposed-tp3496606p3565134.html
Sent from the Netty Developer Group mailing list archive at Nabble.com.


More information about the netty-dev mailing list