[JBoss JIRA] Commented: (NETTY-378) NioWorker - writeTaskQueue may be growing unlimited

[Trustin Lee (JIRA)]

    [ https://issues.jboss.org/browse/NETTY-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12578944#comment-12578944 ] 

Trustin Lee commented on NETTY-378:
-----------------------------------

writeTaskQueue only grows up to the number of open connections.  If you observe it grows a lot more than that, please let me know again with specific steps to reproduce the problem.

> NioWorker - writeTaskQueue may be growing unlimited
> ---------------------------------------------------
>
>                 Key: NETTY-378
>                 URL: https://issues.jboss.org/browse/NETTY-378
>             Project: Netty
>          Issue Type: Bug
>            Reporter: Michal L
>            Assignee: Trustin Lee
>
> NioWorker - writeTaskQueue may be growing unlimited and may cause a VM out of memory error in case of a high amount of traffic.    
> I think that this code from NioWorker:
> private final Queue<Runnable> writeTaskQueue = new LinkedTransferQueue<Runnable>();
> Should better be replaced with a bounded queue.
> In addition, it would be nice to add a possible rejection handler, something like:
> boolean offered = writeTaskQueue.offer(channel.writeTask);
> if (!offered) {
>   rejectedExecutionHandler.rejectedExecution(...);                    
> }
> ...

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira