branch ipfilter

[FrédBrégier]

Hello Ron,

Please go ahead to change or adapt the branch ipfilter as you needed.
As Trustin said, don't forget to check the return of getRemoteAddress()
if used in channelOpen case.

Cheers,
Frederic

Le 25/01/2010 09:07, "Trustin Lee (이희승)" a écrit :
> Hello Ron,
>
> If an additional patterns are added, it will be useful.  However, I
> guess reverse DNS lookup will take longer time?
>
> By API definition, channelOpen does not necessarily mean
> channel.getRemoteAddress() will return non-null, while channelConnected
> does mean that the channel is actually connected.  Practically,
> getRemoteAddress() will return non-null on channelOpen() for server-side
> channels, though.  Perhaps the IpFilterHandler could be improved to
> check the IP in channelOpen, too.
>
> I should merge the branch into the trunk but I must admit it has not
> been a high priority task.  If you are interested and willing to spend
> some time polishing the code and Frederic (the original author, CC'd) is
> fine, I'd love to give you the access to the repository.
>
> Cheers,
> Trustin
>
> PS: Also, please let me know if you want to maintain the asynchronous
> hessian contribution in our svn repository.  I could create a space so
> that you don't need to attach the patch files.
>
> rzo wrote:
>   
>> Hello,
>>
>> what is the state of this branch ? when will this be merged into trunk ?
>> within my patch netty-242 i have implemented something similar which 
>> works with string patterns instead of CIDR.
>> I think that string patterns are easier to understand and allows to 
>> filter by host name.
>>
>> I propose that we merge the implementations.
>>
>> IpFilterHandler checks the ip at CONNECT. Within my implementation the 
>> check is done during OPEN, which happens before CONNECT.
>>
>> Why do you think that CONNECT is a better "place" to do the check ?
>>
>> -- Ron
>> _______________________________________________
>> netty-users mailing list
>> netty-users at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/netty-users
>>     
>