Protobuf helpers inefficiency

[Aleksey Yashchenko]

Hello ALL,

netty samples use ProtobufVarint32FrameDecoder & Co classes to decode
several protobuf messages within one packet. These helpers store VarInt
before each message for this purpose. I've just found that they make a
separete copy of input ChannelBuffer on each decode() instead of using
buffer.slice(). Literally:

return buffer.readBytes(length)

Is there any special idea behind this?

Thanks!

~Leha
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/netty-users/attachments/20110809/383609f1/attachment.html