[portal-commits] JBoss Portal SVN: r5751 - trunk/cms/src/main/org/jboss/portal/cms/impl/jcr/command

[portal-commits at lists.jboss.org]

Author: roy.russo at jboss.com
Date: 2006-12-04 12:31:13 -0500 (Mon, 04 Dec 2006)
New Revision: 5751

Modified:
   trunk/cms/src/main/org/jboss/portal/cms/impl/jcr/command/StoreArchiveCommand.java
Log:
JBPORTAL-1146 - error handling for file size issue.

Modified: trunk/cms/src/main/org/jboss/portal/cms/impl/jcr/command/StoreArchiveCommand.java
===================================================================
--- trunk/cms/src/main/org/jboss/portal/cms/impl/jcr/command/StoreArchiveCommand.java	2006-12-04 15:03:42 UTC (rev 5750)
+++ trunk/cms/src/main/org/jboss/portal/cms/impl/jcr/command/StoreArchiveCommand.java	2006-12-04 17:31:13 UTC (rev 5751)
@@ -70,7 +70,13 @@
             String itemName = zipEntry.getName();
             if (!zipEntry.isDirectory())
             {
-               byte[] zipBytes = new byte[(int)zipEntry.getSize()];
+               long fileSize = zipEntry.getSize();
+               if ((fileSize < 0) || (fileSize > Integer.MAX_VALUE))
+               {
+                  throw new Exception("Error : " + itemName + " Cannot determine uncompressed size!");
+               }
+
+               byte[] zipBytes = new byte[(int)fileSize];
                int offset = 0;
                while (offset < zipBytes.length)
                {