[portal-commits] JBoss Portal SVN: r9033 - in branches/JBoss_Portal_Branch_2_6/core-wsrp/src/resources/portal-wsrp-admin-war: WEB-INF/jsf/consumers and 1 other directory.

[portal-commits at lists.jboss.org]

Author: chris.laprun at jboss.com
Date: 2007-11-19 20:34:26 -0500 (Mon, 19 Nov 2007)
New Revision: 9033

Modified:
   branches/JBoss_Portal_Branch_2_6/core-wsrp/src/resources/portal-wsrp-admin-war/WEB-INF/jsf/consumers/editConsumer.xhtml
   branches/JBoss_Portal_Branch_2_6/core-wsrp/src/resources/portal-wsrp-admin-war/style.css
Log:
- JBPORTAL-1567: 
  + Improved layout.
  + Added description column for registration properties (it used to be only in the row title).
  + Registration properties table is now bordered for better structuring of the page.

Modified: branches/JBoss_Portal_Branch_2_6/core-wsrp/src/resources/portal-wsrp-admin-war/WEB-INF/jsf/consumers/editConsumer.xhtml
===================================================================
--- branches/JBoss_Portal_Branch_2_6/core-wsrp/src/resources/portal-wsrp-admin-war/WEB-INF/jsf/consumers/editConsumer.xhtml	2007-11-20 00:14:29 UTC (rev 9032)
+++ branches/JBoss_Portal_Branch_2_6/core-wsrp/src/resources/portal-wsrp-admin-war/WEB-INF/jsf/consumers/editConsumer.xhtml	2007-11-20 01:34:26 UTC (rev 9033)
@@ -79,24 +79,24 @@
 </tr>
 <c:if test="#{consumer.localInfoPresent}">
    <tr>
-      <th>Registration information</th>
+      <th>Registration information:</th>
       <td>
          <c:choose>
             <c:when test="#{consumer.localInfoPresent}">
                <c:choose>
                   <c:when test="#{!empty consumer.producerInfo.registrationInfo.registrationProperties}">
-                     <table border='1' cellspacing='0' class='registration-prop-table'>
+                     <table class="registration-prop-table #{consumer.active ? 'active' : 'inactive'}">
                         <tr>
-                           <th>Name</th>
+                           <th class="nameColumn">Name</th>
+                           <th class="descColumn">Description</th>
                            <th>Value</th>
                         </tr>
                         <c:forEach items="#{consumer.producerInfo.registrationInfo.registrationProperties}" var="prop">
                            <tr title="#{prop.description.label.value}">
+                              <td>#{prop.name}</td>
+                              <td>#{prop.description.label.value}</td>
                               <td>
-                                 <h:outputText value="#{prop.name}"/>
-                              </td>
-                              <td>
-                                 <h:inputText value="#{prop.value}" size="40" onchange="this.form.submit()"
+                                 <h:inputText value="#{prop.value}" size="50" onchange="this.form.submit()"
                                               immediate="true" valueChangeListener="#{consumer.regPropListener}"/>
                                  <h:outputText styleClass="portlet-msg-error" value="#{prop.status}"
                                                rendered="#{prop.determinedInvalid}"/>
@@ -119,7 +119,7 @@
    <c:if test="#{!empty consumer.producerInfo.registrationInfo.registrationHandle}">
       <tr>
          <th>Registration context:</th>
-         <td>
+         <td id="handle">
             Handle: <h:outputText value="#{consumer.producerInfo.registrationInfo.registrationHandle}"/>
             <h:commandLink action="#{consumer.eraseLocalRegistration}" value="Erase local registration"
                            title="Erase local registration information (potentially dangerous!)"
@@ -138,7 +138,8 @@
    </c:if>
 </c:if>
 <tr>
-   <td colspan="2" style="padding: 1em 1em 1em 0;">
+   <th/>
+   <td class="portlet-section-buttonrow">
       <h:commandButton action="#{consumer.refreshConsumer}" value="Refresh &amp; Save"
                        title="Save changes and refresh information from Producer"
                        styleClass="portlet-form-button"/>

Modified: branches/JBoss_Portal_Branch_2_6/core-wsrp/src/resources/portal-wsrp-admin-war/style.css
===================================================================
--- branches/JBoss_Portal_Branch_2_6/core-wsrp/src/resources/portal-wsrp-admin-war/style.css	2007-11-20 00:14:29 UTC (rev 9032)
+++ branches/JBoss_Portal_Branch_2_6/core-wsrp/src/resources/portal-wsrp-admin-war/style.css	2007-11-20 01:34:26 UTC (rev 9033)
@@ -178,6 +178,7 @@
    border: 0;
    padding-bottom: 2px;
    padding-top: 2px;
+   vertical-align: top;
 }
 
 .wsrp-consumers-ui th {
@@ -246,10 +247,44 @@
 
 .wsrp-consumers-ui .registration-prop-table {
    text-align: left;
-   border: 0;
-   border-collapse: separate;
+   width: 100%;
 }
 
+.wsrp-consumers-ui .registration-prop-table.active {
+   border: 1px solid #C7DDB7;
+}
+
+.wsrp-consumers-ui .registration-prop-table.active th {
+   background-color: #C7DDB7;
+}
+
+.wsrp-consumers-ui .registration-prop-table.inactive {
+   border: 1px solid #EBD1B8;
+}
+
+.wsrp-consumers-ui .registration-prop-table.inactive th {
+   background-color: #EBD1B8;
+}
+
+.wsrp-consumers-ui .registration-prop-table th.nameColumn {
+   width: 25%;
+}
+
+.wsrp-consumers-ui .registration-prop-table th.descColumn {
+   width: 25%;
+}
+
+.wsrp-consumers-ui .portlet-section-buttonrow {
+   margin-top: 6px;
+   margin-bottom: 6px;
+   float: right;
+}
+
+.wsrp-consumers-ui #handle a.portlet-form-button {
+   padding: .2em;
+   margin-left: 3em;
+}
+
 .wsrp-consumers-ui .portlet-form-button {
    padding: .2em;
    margin: 0 .3em;
@@ -281,7 +316,7 @@
 
 .wsrp-consumers-ui .portlet-area-body {
    border: 1px solid #d5d5d5;
-   border-top: 0px;
+   border-top: 0;
    background-color: #fff;
    padding: 4px;
    margin: 0;