[resteasy-dev] resteasy-spring in integration tests

Thu Aug 11 04:21:11 EDT 2016

Hello Alessio,

yes, everything works as expected. The PR for my issue is up.

Martin Stefanko

Associate Software Engineer
JBoss Sustaining Engineering Team
Red Hat Czech s.r.o.

On Thu, Aug 11, 2016 at 9:04 AM, Alessio Soldano <asoldano at redhat.com>
wrote:

> Can you rebase your PR and check the fix I committed allow you to properly
> test your changes?
> Thanks
> Alessio
>
> Il 11/08/2016 07:17, Martin Stefanko ha scritto:
>
> Great. Thank you Alessio.
>
>
> Martin Stefanko
>
> Associate Software Engineer
> JBoss Sustaining Engineering Team
> Red Hat Czech s.r.o.
>
> On Wed, Aug 10, 2016 at 10:15 PM, Alessio Soldano <asoldano at redhat.com>
> wrote:
>
>> Il 10/08/2016 15:25, Alessio Soldano ha scritto:
>>
>> I've had a look. This seems to be a problem in the way the resteasy
>> components are installed to the test server. Th build simply unzip the
>> distribution zip that's created in jboss-modules module, while it should
>> actually clean up the former resteasy version first (or at least clean that
>> resteasy-spring bundle dir).
>> Just yesterday I thought I could probably delay re-writing the
>> installation mechanism... now I think we at least need a fix here.
>> Please create a jira and assign it to me.
>>
>> Nevermind, just committed a fix as part of RESTEASY-1361:
>> https://github.com/resteasy/Resteasy/pull/891/commits/f82059
>> e5293af2d0c42ba0b25a545edd8da0aceb
>>
>> Cheers
>> Alessio
>>
>> Cheers
>> Alessio
>>
>> Il 10/08/2016 13:54, Martin Stefanko ha scritto:
>>
>>
>> Hi,
>>
>> sorry for the misconception. The resteasy-spring.jar contains the latest
>> version of the module, but I don't see why the final name attribute is used
>> [1]. The problem is that the module.xml specifies only the directory "
>> bundled/resteasy-spring-jar" which also contains the "
>> resteasy-spring-3.0.14.Final.jar" which it seems is taking precedence.
>>
>>
>> [1] https://github.com/resteasy/Resteasy/blob/master/resteas
>> y-spring/pom.xml#L184
>> [2] https://github.com/resteasy/Resteasy/blob/master/jboss-
>> modules/build-wf8.xml#L156
>>
>>
>> Martin Stefanko
>>
>> Associate Software Engineer
>> JBoss Sustaining Engineering Team
>> Red Hat Czech s.r.o.
>>
>> On Wed, Aug 10, 2016 at 12:18 PM, Martin Stefanko < <mstefank at redhat.com>
>> mstefank at redhat.com> wrote:
>>
>>> Forwarding to mailing list.
>>>
>>>
>>> Hello Alessio,
>>>
>>> --> can you provide a link to that discussion please?
>>>
>>> I found out that it was a private communication. I'll find a way to pass
>>> it to you.
>>>
>>>
>>> --> Can you clarify this a bit? Did you check if resteasy's
>>> jboss-modules module is properly replacing resteasy-spring the way it does
>>> with other components?
>>>
>>> yes, the resteasy-spring is not being properly replaced.
>>>
>>> The directory "Resteasy/testsuite/integratio
>>> n-tests-spring/deployment/target/test-server/wildfly-10.0.0.
>>> Final/modules/system/layers/base/org/jboss/resteasy/resteasy
>>> -spring/main/bundled/resteasy-spring-jar" contains the
>>> "resteasy-spring.jar" and "resteasy-spring-3.0.14.Final.jar". I think
>>> the resteasy-spring.jar is used which does not contain the latest version.
>>>
>>> In WF "wildfly-11.0.0.Alpha1-SNAPSHOT/modules/system/layers/base/o
>>> rg/jboss/resteasy/resteasy-spring/main/bundled/resteasy-spring-jar"
>>> contains only the "resteasy-spring-3.0.19.Final.jar".
>>>
>>>
>>> Martin Stefanko
>>>
>>> Associate Software Engineer
>>> JBoss Sustaining Engineering Team
>>> Red Hat Czech s.r.o.
>>>
>>> On Wed, Aug 10, 2016 at 10:04 AM, Alessio Soldano <
>>> <asoldano at redhat.com>asoldano at redhat.com> wrote:
>>>
>>>> Hi Martin,
>>>>
>>>> Il 05/08/2016 10:20, Martin Stefanko ha scritto:
>>>>
>>>>
>>>> Hello all,
>>>>
>>>> For my issue [1], I changed the resteasy-spring module but this change
>>>> is not reflected in the integration tests (integration-tests-spring/deployment).
>>>> There was already a discussion similar to this topic on the mailing list
>>>> about integration of the Spring in the project.
>>>>
>>>> can you provide a link to that discussion please?
>>>>
>>>>
>>>> resteasy-spring is bundled in the server and it is not being replaced
>>>> with the most recent version. I am adding links to the commit [2] and the
>>>> build log [3]. With this we do not have any chance to change this module.
>>>>
>>>> Can you clarify this a bit? Did you check if resteasy's jboss-modules
>>>> module is properly replacing resteasy-spring the way it does with other
>>>> components?
>>>>
>>>> Cheers
>>>> Alessio
>>>>
>>>>
>>>>
>>>> [1] <https://issues.jboss.org/browse/RESTEASY-1287>
>>>> https://issues.jboss.org/browse/RESTEASY-1287
>>>> [2]
>>>> <https://github.com/xstefank/Resteasy/commit/1911ac0720bf964698d8c64ed82345c09d18c80f>
>>>> https://github.com/xstefank/Resteasy/commit/1911ac0720bf
>>>> 964698d8c64ed82345c09d18c80f
>>>> [3]  <https://travis-ci.org/xstefank/Resteasy/builds/149760402>
>>>> https://travis-ci.org/xstefank/Resteasy/builds/149760402
>>>>
>>>> Martin Stefanko
>>>>
>>>> Associate Software Engineer
>>>> JBoss Sustaining Engineering Team
>>>> Red Hat Czech s.r.o.
>>>>
>>>>
>>>> _______________________________________________
>>>> resteasy-dev mailing listresteasy-dev at lists.jboss.orghttps://lists.jboss.org/mailman/listinfo/resteasy-dev
>>>>
>>>> --
>>>> Alessio Soldano
>>>> Web Service Lead, JBoss
>>>>
>>>> _______________________________________________ resteasy-dev mailing
>>>> list resteasy-dev at lists.jboss.org https://lists.jboss.org/mailma
>>>> n/listinfo/resteasy-dev
>>>
>>> _______________________________________________
>> resteasy-dev mailing listresteasy-dev at lists.jboss.orghttps://lists.jboss.org/mailman/listinfo/resteasy-dev
>>
>> --
>> Alessio Soldano
>> Web Service Lead, JBoss
>>
>> _______________________________________________
>> resteasy-dev mailing listresteasy-dev at lists.jboss.orghttps://lists.jboss.org/mailman/listinfo/resteasy-dev
>>
>> --
>> Alessio Soldano
>> Web Service Lead, JBoss
>>
>> _______________________________________________ resteasy-dev mailing
>> list resteasy-dev at lists.jboss.org https://lists.jboss.org/mailma
>> n/listinfo/resteasy-dev
>
> --
> Alessio Soldano
> Web Service Lead, JBoss
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/resteasy-dev/attachments/20160811/74733722/attachment-0001.html 