[resteasy-dev] Remove top jaxrs dir in upstream
Alessio Soldano
asoldano at redhat.com
Tue May 24 18:27:05 EDT 2016
Thanks, I was planning to do that as next step, but I'll cherry-pick
your commit instead ;-)
Alessio
Il 24/05/2016 23:56, Tomaž Cerar ha scritto:
> Alessio,
>
> I've added extra commit on top of commits in your PR
> that fixes all maven warnings about inconsistent/problematic pom.xml
> structure.
> you can cherry pick it from my branch
> https://github.com/resteasy/Resteasy/compare/master...ctomc:small-build-fix
> and include it in your PR.
>
> Or I can send PR once yours is merged.
>
> --
> tomaz
>
>
>
>
> On Tue, May 24, 2016 at 11:16 PM, Tomaž Cerar <tomaz.cerar at gmail.com
> <mailto:tomaz.cerar at gmail.com>> wrote:
>
> well, i cannot reproduce you failure as i get failure earlier in
> the build
> (on windows 10 / JDK8u74
>
> but it does look like they follow the same pattern, with the
> address already in use.
> they all come from TJWS web server and its testsuite.
>
> I think this should be merged, than we can all chip in to fix the
> failures we find on our platforms.
>
> As my experience from the past is that testsuite never passed for
> me anyway.
> it cannot be worse.
>
> --
> tomaz
>
>
> On Tue, May 24, 2016 at 10:32 PM, Rebecca Searls
> <rsearls at redhat.com <mailto:rsearls at redhat.com>> wrote:
>
>
> Fedora 23
> JDK 1.7.0_55
>
>
>
>
> ----- Original Message -----
> > From: "Tomaž Cerar" <tomaz.cerar at gmail.com
> <mailto:tomaz.cerar at gmail.com>>
> > To: "Rebecca Searls" <rsearls at redhat.com
> <mailto:rsearls at redhat.com>>
> > Cc: "Alessio Soldano" <asoldano at redhat.com
> <mailto:asoldano at redhat.com>>, resteasy-dev at lists.jboss.org
> <mailto:resteasy-dev at lists.jboss.org>
> > Sent: Tuesday, May 24, 2016 4:27:23 PM
> > Subject: Re: [resteasy-dev] Remove top jaxrs dir in upstream
> >
> > what platform / jdk are you on?
> >
> > On Tue, May 24, 2016 at 10:14 PM, Rebecca Searls
> <rsearls at redhat.com <mailto:rsearls at redhat.com>> wrote:
> >
> > >
> > > I checked there is no old running instance.
> > > Usually when that happens I get an error about a port
> already under use.
> > >
> > > I found the missing class very odd as well. I've done
> nothing but
> > > checkout the code and run it.
> > > I haven't touched anything.
> > >
> > >
> > > ----- Original Message -----
> > > > From: "Alessio Soldano" <asoldano at redhat.com
> <mailto:asoldano at redhat.com>>
> > > > To: "Rebecca Searls" <rsearls at redhat.com
> <mailto:rsearls at redhat.com>>
> > > > Cc: resteasy-dev at lists.jboss.org
> <mailto:resteasy-dev at lists.jboss.org>
> > > > Sent: Tuesday, May 24, 2016 4:09:21 PM
> > > > Subject: Re: [resteasy-dev] Remove top jaxrs dir in upstream
> > > >
> > > > mmh... strange... perhaps you have (forgotten) a wfly
> instance running
> > > > on the same machine? Just wondering..
> > > >
> > > > Il 24/05/2016 22:05, Rebecca Searls ha scritto:
> > > > > Yes, I'm using mvn clean install
> > > > > mvn test -rf :RESTEASY-903-WF8 ; This did not get
> me past the
> > > failure.
> > > > >
> > > > > Here is the cause of the deployment failure.
> > > > > (I've attached the server.log for more detailed
> information)
> > > > >
> > > > > 2016-05-24 15:59:42,741 ERROR
> > > > > [org.jboss.as.controller.management-operation]
> > > (management-handler-thread
> > > > > - 4) JBAS014613: Operation ("deploy") failed - address:
> > > ([("deployment" =>
> > > > > "RESTEASY-903.war")]) - failure description:
> {"JBAS014771: Services
> > > with
> > > > > missing/unavailable dependencies" =>
> > > > >
> > >
> ["jboss.naming.context.java.module.RESTEASY-903.RESTEASY-903.DefaultJMSConnectionFactory
> > > > > is missing
> > > > >
> [jboss.naming.context.java.jboss.DefaultJMSConnectionFactory]"]}
> > > > >
> > > > >
> > > > >
> > > > > ----- Original Message -----
> > > > >> From: "Alessio Soldano" <asoldano at redhat.com
> <mailto:asoldano at redhat.com>>
> > > > >> To: "Rebecca Searls" <rsearls at redhat.com
> <mailto:rsearls at redhat.com>>
> > > > >> Cc: resteasy-dev at lists.jboss.org
> <mailto:resteasy-dev at lists.jboss.org>
> > > > >> Sent: Tuesday, May 24, 2016 3:26:22 PM
> > > > >> Subject: Re: [resteasy-dev] Remove top jaxrs dir in
> upstream
> > > > >>
> > > > >> It's definitely not expected, but I can't reproduce
> it here.
> > > > >> Btw, Travis also successfully passed the tests below,
> even if it later
> > > > >> failed on a different one. I've restarted the build
> there.
> > > > >> Which command are you using? 'mvn clean install' ?
> Are you able to get
> > > > >> through the failure by re-running the build (perhaps
> even using -rf
> > > > >> :RESTEASY-903-WF8 option) ?
> > > > >>
> > > > >> Cheers
> > > > >> Alessio
> > > > >>
> > > > >> Il 24/05/2016 18:56, Rebecca Searls ha scritto:
> > > > >>> The structure looks good.
> > > > >>>
> > > > >>> I get a build failure when the tests are run. Is
> this expected.
> > > > >>>
> > > > >>> mvn clean install
> > > > >>>
> > > > >>> [INFO] RESTEASY-903-WF8
> ...................................
> > > FAILURE
> > > > >>> [
> > > > >>> 6.727 s]
> > > > >>> Tests in error:
> > > > >>> org.jboss.resteasy.test.resteasy903.UndertowTest:
> Cannot
> > > > >>> deploy:
> > > > >>> RESTEASY-903.war
> > > > >>> org.jboss.resteasy.test.resteasy903.FilterTest: Cannot
> > > deploy:
> > > > >>> RESTEASY-903.war
> > > > >>>
> > > > >>>
> > > > >>>
> > > > >>> ----- Original Message -----
> > > > >>>> From: "Alessio Soldano" <asoldano at redhat.com
> <mailto:asoldano at redhat.com>>
> > > > >>>> To: resteasy-dev at lists.jboss.org
> <mailto:resteasy-dev at lists.jboss.org>
> > > > >>>> Sent: Tuesday, May 24, 2016 12:06:40 PM
> > > > >>>> Subject: Re: [resteasy-dev] Remove top jaxrs dir in
> upstream
> > > > >>>>
> > > > >>>> The first PR for RESTEASY-1361 is being tested now
> (passed locally):
> > > > >>>> https://github.com/resteasy/Resteasy/pull/808
> > > > >>>> It includes removal of the jaxrs dir and pruning of
> the examples
> > > (the
> > > > >>>> jaxrs
> > > > >>>> 2.0 samples are still there, tested by default,
> while other examples
> > > > >>>> have
> > > > >>>> been moved to
> https://github.com/resteasy/resteasy-examples )
> > > > >>>>
> > > > >>>> Please have a look, I'd like to have this merged by
> tomorrow, so
> > > that we
> > > > >>>> can
> > > > >>>> go on with the build improvements.
> > > > >>>>
> > > > >>>> Cheers
> > > > >>>> Alessio
> > > > >>>>
> > > > >>>> Il 21/05/2016 01:25, Ron Sigal ha scritto:
> > > > >>>>
> > > > >>>>
> > > > >>>>
> > > > >>>>
> > > > >>>> Got it. Thanks, guys.
> > > > >>>>
> > > > >>>> On 05/20/2016 03:36 PM, Alessio Soldano wrote:
> > > > >>>>
> > > > >>>>
> > > > >>>>
> > > > >>>> Il 20/05/2016 19:35, Weinan Li ha scritto:
> > > > >>>>
> > > > >>>>
> > > > >>>>
> > > > >>>> - Weinan Li
> > > > >>>>
> > > > >>>>
> > > > >>>>
> > > > >>>> On May 21, 2016, at 1:24 AM, Ron Sigal
> <rsigal at redhat.com <mailto:rsigal at redhat.com>> wrote:
> > > > >>>>
> > > > >>>> Two questions.
> > > > >>>>
> > > > >>>> 1. jaxrs will continue to exist on the 3.0.x
> branch, right?
> > > > >>>> Right(I guess so).
> > > > >>>> Sure
> > > > >>>>
> > > > >>>>
> > > > >>>>
> > > > >>>>
> > > > >>>>
> > > > >>>> 2. More generally, what exactly goes into branch
> 3.0.x? I assume
> > > just
> > > > >>>> bug
> > > > >>>> fixes. Are they just bug fixes that come out of EAP
> 7? Or do all bug
> > > > >>>> fixes
> > > > >>>> have to be applied to both 3.0.x and master?
> > > > >>>> IMHO we should fully focus on 3.1.x from now on,
> and next release
> > > goes
> > > > >>>> into
> > > > >>>> Wildfly will be 3.1.0.
> > > > >>>> Exactly. We might decide to do another 3.0.x
> release if there's
> > > really
> > > > >>>> need to (for instance should we figure out
> 3.0.17.Final has a
> > > critical
> > > > >>>> issue deserving another community fix release).
> However the focus
> > > should
> > > > >>>> now be on 3.1.x.
> > > > >>>>
> > > > >>>> Cheers
> > > > >>>> Alessio
> > > > >>>>
> > > > >>>>
> > > > >>>>
> > > > >>>> For 3.0.x, I guess we should treat it similar like
> 2.3.x, and only
> > > > >>>> maintain
> > > > >>>> it for EAP one-offs and CVE fixes in
> redhat-resteasy repo.
> > > > >>>>
> > > > >>>>
> > > > >>>>
> > > > >>>> -Ron
> > > > >>>>
> > > > >>>> On 05/20/2016 05:39 AM, Weinan Li wrote:
> > > > >>>>
> > > > >>>>
> > > > >>>>
> > > > >>>> Hi Team,
> > > > >>>>
> > > > >>>> I'm planning to remove 'jaxrs' top dir next week,
> which I guess will
> > > > >>>> affect
> > > > >>>> all the open PRs, wdyt?
> > > > >>>>
> > > > >>>> --
> > > > >>>> Weinan Li / JBoss
> > > > >>>>
> > > > >>>>
> > > > >>>> _______________________________________________
> > > > >>>> resteasy-dev mailing list
> resteasy-dev at lists.jboss.org <mailto:resteasy-dev at lists.jboss.org>
> > > > >>>> https://lists.jboss.org/mailman/listinfo/resteasy-dev
> > > > >>>> --
> > > > >>>> My company's smarter than your company (unless you
> work for Red Hat)
> > > > >>>>
> > > > >>>> _______________________________________________
> > > > >>>> resteasy-dev mailing list
> resteasy-dev at lists.jboss.org <mailto:resteasy-dev at lists.jboss.org>
> > > > >>>> https://lists.jboss.org/mailman/listinfo/resteasy-dev
> > > > >>>> _______________________________________________
> > > > >>>> resteasy-dev mailing list
> resteasy-dev at lists.jboss.org <mailto:resteasy-dev at lists.jboss.org>
> > > > >>>> https://lists.jboss.org/mailman/listinfo/resteasy-dev
> > > > >>>>
> > > > >>>> --
> > > > >>>> My company's smarter than your company (unless you
> work for Red Hat)
> > > > >>>>
> > > > >>>>
> > > > >>>> _______________________________________________
> > > > >>>> resteasy-dev mailing list
> resteasy-dev at lists.jboss.org <mailto:resteasy-dev at lists.jboss.org>
> > > > >>>> https://lists.jboss.org/mailman/listinfo/resteasy-dev
> > > > >>>>
> > > > >>>>
> > > > >>>> --
> > > > >>>> Alessio Soldano
> > > > >>>> Web Service Lead, JBoss
> > > > >>>>
> > > > >>>> _______________________________________________
> > > > >>>> resteasy-dev mailing list
> > > > >>>> resteasy-dev at lists.jboss.org
> <mailto:resteasy-dev at lists.jboss.org>
> > > > >>>> https://lists.jboss.org/mailman/listinfo/resteasy-dev
> > > > >>>>
> > > > >>
> > > > >> --
> > > > >> Alessio Soldano
> > > > >> Web Service Lead, JBoss
> > > > >>
> > > > >>
> > > >
> > > >
> > > > --
> > > > Alessio Soldano
> > > > Web Service Lead, JBoss
> > > >
> > > >
> > > _______________________________________________
> > > resteasy-dev mailing list
> > > resteasy-dev at lists.jboss.org
> <mailto:resteasy-dev at lists.jboss.org>
> > > https://lists.jboss.org/mailman/listinfo/resteasy-dev
> > >
> >
>
>
>
--
Alessio Soldano
Web Service Lead, JBoss
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/resteasy-dev/attachments/20160525/65384f01/attachment-0001.html
More information about the resteasy-dev
mailing list