[richfaces-issues] [JBoss JIRA] Resolved: (RF-3992) graphValidator: empty values causes exception instead of messages

[Alexander Smirnov (JIRA)]

     [ https://jira.jboss.org/jira/browse/RF-3992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexander Smirnov resolved RF-3992.
-----------------------------------

    Resolution: Done


There was incorrect checking for a null value. Fixed

> graphValidator: empty values causes exception instead of messages
> -----------------------------------------------------------------
>
>                 Key: RF-3992
>                 URL: https://jira.jboss.org/jira/browse/RF-3992
>             Project: RichFaces
>          Issue Type: Bug
>    Affects Versions: 3.2.1
>            Reporter: Ilya Shaikovsky
>            Assignee: Alexander Smirnov
>             Fix For: 3.2.2
>
>
> 		<rich:panel>
> 			<f:facet name="header">
> 				<h:outputText value="User Info:" />
> 			</f:facet>
> 			<rich:graphValidator>
> 				<h:panelGrid columns="3">
> 					<h:outputText value="Name:" />
> 					<h:inputText value="#{validationBean.name}" id="name"/>
> 					<rich:message for="name" />
> 					<h:outputText value="Email:" />
> 					<h:inputText value="#{validationBean.email}" id="email"/>
> 					<rich:message for="email" />
> 					<h:outputText value="Age:" />
> 					<h:inputText value="#{validationBean.age}" id="age"/>
> 					<rich:message for="age" />
> 				</h:panelGrid>
> 			</rich:graphValidator>
> 			<a4j:commandButton value="Store changes"/>
> 		</rich:panel>
> If I enter nothing in fields and click button:
> javax.faces.FacesException: Input parameters is not correct.
> 	at org.richfaces.validator.BeanValidator.checkInputParameters(BeanValidator.java:142)
> 	at org.richfaces.validator.BeanValidator.validate(BeanValidator.java:107)
> 	at org.richfaces.validator.FacesBeanValidator.validate(FacesBeanValidator.java:43)
> 	at org.richfaces.component.html.HtmlInputText.validateValue(HtmlInputText.java:35)
> 	at javax.faces.component.UIInput.validate(UIInput.java:875)
> 	at javax.faces.component.UIInput.executeValidate(UIInput.java:1072)
> 	at javax.faces.component.UIInput.processValidators(UIInput.java:672)
> 	at javax.faces.component.UIComponentBase.processValidators(UIComponentBase.java:1058)
> 	at javax.faces.component.UIComponentBase.processValidators(UIComponentBase.java:1058)
> 	at javax.faces.component.UIComponentBase.processValidators(UIComponentBase.java:1058)
> 	at javax.faces.component.UIForm.processValidators(UIForm.java:235)
> 	at javax.faces.component.UIComponentBase.processValidators(UIComponentBase.java:1058)
> 	at org.richfaces.component.UISwitchablePanel.processValidators(UISwitchablePanel.java:236)
> 	at org.ajax4jsf.component.AjaxViewRoot$3.invokeContextCallback(AjaxViewRoot.java:435)
> 	at org.ajax4jsf.component.ContextCallbackWrapper.invokeContextCallback(ContextCallbackWrapper.java:24)
> 	at org.ajax4jsf.component.AjaxViewRoot.processPhase(AjaxViewRoot.java:235)
> 	at org.ajax4jsf.component.AjaxViewRoot.processValidators(AjaxViewRoot.java:451)
> 	at com.sun.faces.lifecycle.ProcessValidationsPhase.execute(ProcessValidationsPhase.java:76)
> 	at com.sun.faces.lifecycle.Phase.doPhase(Phase.java:100)
> 	at com.sun.faces.lifecycle.LifecycleImpl.execute(LifecycleImpl.java:118)
> 	at javax.faces.webapp.FacesServlet.service(FacesServlet.java:265)
> 	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
> 	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
> 	at org.ajax4jsf.webapp.BaseXMLFilter.doXmlFilter(BaseXMLFilter.java:150)
> 	at org.ajax4jsf.webapp.BaseFilter.handleRequest(BaseFilter.java:267)
> 	at org.ajax4jsf.webapp.BaseFilter.processUploadsAndHandleRequest(BaseFilter.java:379)
> 	at org.ajax4jsf.webapp.BaseFilter.doFilter(BaseFilter.java:506)
> 	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
> 	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
> 	at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
> 	at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:175)
> 	at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:128)
> 	at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
> 	at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
> 	at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:286)
> 	at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:844)
> 	at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:583)
> 	at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:447)
> 	at java.lang.Thread.run(Thread.java:595)
> exception thrown at:
> 	// Method for checking input parameters for prevent NPE
> 	private void checkInputParameters(FacesContext context,
> 			ValueExpression target, Object value) {
> 		if (null == context || null == target || null == value) {
> 			throw new FacesException(INPUT_PARAMETERS_IS_NOT_CORRECT);
> 		}
> 	}

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira