[richfaces-issues] [JBoss JIRA] Commented: (RF-997) Calendar - incorrect use of converters

Daniel Soneira (JIRA) jira-events at lists.jboss.org
Wed Mar 5 06:49:58 EST 2008


    [ http://jira.jboss.com/jira/browse/RF-997?page=comments#action_12401381 ] 
            
Daniel Soneira commented on RF-997:
-----------------------------------

Today I stumbled again over this mess of CalendarRendererBase.getSelectedDate...
I will upload a modified example war file.

I will make this as clear as possible. The last fix was a dirty hack and did not solve the misuse of conversion code in the renderer at all.

THIS time PLEASE rewrite your calendar code:
Renderer renders, Converter converts, Component stores value - the way it was meant to be.

Please reopen this issue.

Thanks,
Daniel

> Calendar - incorrect use of converters
> --------------------------------------
>
>                 Key: RF-997
>                 URL: http://jira.jboss.com/jira/browse/RF-997
>             Project: RichFaces
>          Issue Type: Bug
>    Affects Versions: 3.1.0
>            Reporter: Maksim Kaszynski
>         Assigned To: Viktor Volkov
>             Fix For: 3.2.0, 3.1.3
>
>         Attachments: calendar.war
>
>
> Calendar component uses converter.getAsObject on render phase. 
> This is wrong. 
> Correct behavior - use converter.getAsObject  on process validations phase.
> In case of bad user input - converter will give conversion exception, display submitted value in input field, in calendar grid select last user selected day (if exists).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        



More information about the richfaces-issues mailing list