[richfaces-issues] [JBoss JIRA] Resolved: (RF-995) SkinFactory cannot be overriden reliably.

Tue Mar 25 06:23:40 EDT 2008

     [ http://jira.jboss.com/jira/browse/RF-995?page=all ]

Vladislav Baranov resolved RF-995.
----------------------------------

    Resolution: Done
      Assignee: Tsikhon Kuprevich  (was: Vladislav Baranov)

Fixed in trunk.
The origin of the issue was in usage of the ClassLoader not available in the moment of instantiation of SkinFactory. Changed to proper ClassLoader available from the cuttent Thread.
When exception is thrown during the instantiation of the SkinFactory, it is wrapped in the FacesException.

> SkinFactory cannot be overriden reliably.
> -----------------------------------------
>
>                 Key: RF-995
>                 URL: http://jira.jboss.com/jira/browse/RF-995
>             Project: RichFaces
>          Issue Type: Bug
>    Affects Versions: 3.1.0
>            Reporter: Chris Rudd
>         Assigned To: Tsikhon Kuprevich
>            Priority: Blocker
>             Fix For: 3.2.0
>
>
> Prior to 3.1.0 the default SkinFactory could be replaced by specifing the implementation class in the resource : META-INF/services/org.richfaces.skin.SkinFactory
> As of 3.1.0 there is no "default" implementation, and the richfaces-impl.jar now defines the resource inorder to specify the implementation. 
> This causes a problem when attempting to override the implemenation, as resources are found in whatever order the jars are in the classpath. There is no reliable way to ensure that the resource located in the jar providing the overriding implementation appears first (before the richfaces-impl).
> I would suggest reserving the service file for the ability to override the default implementation, and introduce a new file to define the default implementation, or reference the default implemenation by name (to prevent the hard reference)
>  

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira