[richfaces-issues] [JBoss JIRA] Commented: (RF-3488) DataScrollerPhaseListener searches component tree when not using datascroller component

[Nick Belaevski (JIRA)]

    [ http://jira.jboss.com/jira/browse/RF-3488?page=comments#action_12413490 ] 
            
Nick Belaevski commented on RF-3488:
------------------------------------

You are abolutely right, that is done to reset the pagination.

Actually, there's no way to discover whether datascroller components are present in component tree or not rather than traversing the whole tree because of the fact that components can be created programmatically.

If that's traversing is unwanted than I propose to introduce init parameter that would switch that behavior off. Ilya, please provide a name for this

> DataScrollerPhaseListener searches component tree when not using datascroller component
> ---------------------------------------------------------------------------------------
>
>                 Key: RF-3488
>                 URL: http://jira.jboss.com/jira/browse/RF-3488
>             Project: RichFaces
>          Issue Type: Bug
>    Affects Versions: 3.2.0
>         Environment: RichFaces 3.2.0.SR1 + Seam 2.0.1.GA + JBoss AS 4.2.2.GA
>            Reporter: Peter Brewer
>            Priority: Minor
>             Fix For: Future
>
>
> The org.richfaces.component.DataScrollerPhaseListener adds a phase listener that always searches through the component tree looking for a DataScroller component (to reset the pagination I think), evaluating the isRendered flag on each component.
> I would suggest that, if possible, this should only occur when a DataScroller component is actually present on the page, avoiding the overhead of searching the entire component tree on each request. (Could the DataScroller component store its id in the view root attributes to switch the searching on/ off?)
> Also, the evaluation of the rendered attribute by the phase listener ought to be documented to aid developers.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira