[richfaces-issues] [JBoss JIRA] Commented: (RF-6473) fileUpload allowFlash="true" not working when inside modalPanel, in IE6

Wed Dec 23 10:07:31 EST 2009

    [ https://jira.jboss.org/jira/browse/RF-6473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12501517#action_12501517 ] 

Jay Balunas commented on RF-6473:
---------------------------------

Comments from Pavel:

I've found problem. The problem is in the ModalPanel.
The problem in modalPanel.js file in "show" method:
line 697:
            Element.hide(eCdiv); //<- here is the promlem. 
            element.style.visibility = "";

            this.lastOnfocus();

            Element.show(eCdiv);

Before line 697 our panel and content is shown. But in the line 697 we hide the panel's content.  As result, flash component lose functions these we call from fileupload javascript to control flash component. I don't know why it happened. I think flash control initialization happened twice because of modal panel content is shown twice.

Solution is to comment line for IE6 697: Element.hide(eCdiv);

Jay: Note this need to be tested and reviewed because it may cause problems with older FF browsers.  This line was added for a reason. 

> fileUpload allowFlash="true" not working when inside modalPanel, in IE6
> -----------------------------------------------------------------------
>
>                 Key: RF-6473
>                 URL: https://jira.jboss.org/jira/browse/RF-6473
>             Project: RichFaces
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>    Affects Versions: 3.3.0
>         Environment: RichFaces 3.3.0.GA, JSF 1.2_12, Seam 2.1.1.GA, Tomcat 5.5.26, Windows XP
>            Reporter: Daniel Wiell
>            Assignee: Pavel Yaschenko
>            Priority: Minor
>             Fix For: Future
>
>
> fileUpload allowFlash="true" not working when inside modalPanel, in IE6
> When using IE6, the actual upload "hangs" right away. It works fine with Firefox 3 and Chrome.
> Note that this is not the same issue as RF-4480, where the button of the file upload didn't open the file dialog window.
> Here is a snippet to recreate it:
> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
>         "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
> <html xmlns="http://www.w3.org/1999/xhtml"
>       xmlns:rich="http://richfaces.org/rich"
>       xmlns:a4j="http://richfaces.org/a4j"
>       xmlns:f="http://java.sun.com/jsf/core"
>       xmlns:h="http://java.sun.com/jsf/html">
> <head>
>     <meta http-equiv="Content-Type" content="text/xhtml; charset=UTF-8"/>
>     <title>File upload</title>
> </head>
> <body>
> <rich:modalPanel id="panel" width="350" autosized="true">
>     <f:facet name="controls">
>         <h:panelGroup>
>             <h:outputText id="hidelink" value="close"/>
>             <rich:componentControl for="panel" attachTo="hidelink" operation="hide" event="onclick"/>
>         </h:panelGroup>
>     </f:facet>
>     <h:form>
>         <rich:fileUpload allowFlash="true" fileUploadListener="#{test.onUpload}"/>
>     </h:form>
> </rich:modalPanel>
> <h:outputLink value="#" id="link">
>     Show Modal Panel
>     <rich:componentControl for="panel" attachTo="link" operation="show" event="onclick"/>
> </h:outputLink>
> <br/>
> </body>
> </html>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira