[richfaces-issues] [JBoss JIRA] Commented: (RF-7634) UIRichMessages doesn't render global messages when globalOnly is false

[Michael Seghers (JIRA)]

    [ https://jira.jboss.org/jira/browse/RF-7634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12478494#action_12478494 ] 

Michael Seghers commented on RF-7634:
-------------------------------------

If I add a global message to the FacesContext, and put a <rich:messages/> on my page, I do not get the message. This is in my opinion logical, since we the get in the "else" condition, which only considers message for components, not the global ones. I checked this in 3.3.0 and looked at the code in 3.3.1 and saw no changes. If I use a regular <h:messages/> tag, the message appears.

> UIRichMessages doesn't render global messages when globalOnly is false
> ----------------------------------------------------------------------
>
>                 Key: RF-7634
>                 URL: https://jira.jboss.org/jira/browse/RF-7634
>             Project: RichFaces
>          Issue Type: Bug
>          Components: component-output
>    Affects Versions: 3.3.0, 3.3.1
>            Reporter: Michael Seghers
>            Assignee: Nick Belaevski
>             Fix For: 3.3.2.CR1
>
>
> Taken following code snippet from the UIRichMessages.getMessages(FacesContext)
> if (isGlobalOnly()) {
> 	addMessagesForId(context, null, severenities);
> } else if (null != forInputId) {
> 	UIComponent componentFor = RendererUtils.getInstance()
> 		.findComponentFor(context, this, forInputId);
> 	if (null != componentFor) {
> 		addMessagesForId(context, componentFor.getClientId(context), severenities);
> 	}
> } else {
> 	Iterator<String> clientIdsWithMessages = context.getClientIdsWithMessages();
> 	while (clientIdsWithMessages.hasNext()) {
> 		addMessagesForId(context, clientIdsWithMessages.next(), severenities);
> 	}
> }
> This means that the call to addMessagesForId(context, null, severenities) is only called in when  globalOnly is true, but it should also be called in the last else part, where all messages should be rendered.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira