[richfaces-issues] [JBoss JIRA] Commented: (RF-6456) [SuggestionBox] SuggestionAction called twice during request if usingSuggestObjects = true

[pschor (JIRA)]

    [ https://jira.jboss.org/jira/browse/RF-6456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12457792#action_12457792 ] 

pschor commented on RF-6456:
----------------------------

to clarify my previous post, I see I have two options:
1) usingSuggestObjects=true - the client will make an unnecessary second call to the server (still don't understand why a second call is needed). Second call is very expensive, and the developer hardly explained his reasoning.
2) usingSuggestObjects=false - original behavior, the client app will make several calls to the server. This behavior shouldn't have been developed this way from the beginning, it's unusable.

My opinion: one of the benefits of open source is peer review, was this featured peer reviewed? the second call is very expensive and doesn't make sense.


> [SuggestionBox] SuggestionAction called twice during request if usingSuggestObjects = true
> ------------------------------------------------------------------------------------------
>
>                 Key: RF-6456
>                 URL: https://jira.jboss.org/jira/browse/RF-6456
>             Project: RichFaces
>          Issue Type: Bug
>    Affects Versions: 3.3.0
>            Reporter: Gerrit Brehmer
>
> SuggestionAction is called twice, if usingSuggestObjects is activated. I looked into the sourcecode and found the two calls:
> - Action with value from request/input field (method setupValue - setValue(suggestingAction.invoke(context.getELContext(), new Object[]{submittedValue}));)
> - Action with "null" as string (method getRequestValuesData - setValue(suggestingAction.invoke(context.getELContext(), new Object[]{requestedValue}));)
> (SourceCode from UiSuggestionBox.java Tag 3.3.0)
> Is the second call really necessary? Because we call an expensive backend method (200ms - 7000ms for address suggest) this makes a noticable delay for the user
> Our workaround is to return an empty list for the second call, which doesn't change the behaviour

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira